From: Joel Fernandes <joel@joelfernandes.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
rcu <rcu@vger.kernel.org>, Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH RFC] rcu/nocb: Provide default all-CPUs mask for RCU_NOCB_CPU=y
Date: Thu, 14 Apr 2022 19:19:48 +0000 [thread overview]
Message-ID: <Ylhz1LOIf+JyjH7n@google.com> (raw)
In-Reply-To: <20220411154109.GX4285@paulmck-ThinkPad-P17-Gen-1>
On Mon, Apr 11, 2022 at 08:41:09AM -0700, Paul E. McKenney wrote:
[..]
> > > [4] All CPUs are offloaded at boot, and any CPU can be de-offloaded
> > > and offloaded at runtime. This is the same behavior that
> > > you would currently get with CONFIG_RCU_NOCB_CPU_ALL=n and
> > > rcu_nocbs=0-N.
> >
> > Yes, this is the behavior I intend. So then there would not be a need
> > to pass a mask (and I suspect for a large number of users, it
> > simplifies boot params).
>
> Very good, and from what I can see, this should work for everyone.
Just to clarify, what I am going to do is, if this new option =y, then
rcu_nocbs effectively wont do anything. i.e. All CPUs are offloaded at boot.
Let me know if we are not on the same page about it though. I do feel that is
a sensible choice given =y. If we are on same page, please ignore my comment.
> > > I believe that Steve Rostedt's review would carry weight for ChromeOS,
> > > however, I am suffering a senior moment on the right person for Android.
> >
> > I think for Android, Kalesh Singh is in the kernel team and Tim Murray
> > is the performance lead. They could appropriately represent their RCU
> > needs.
>
> Sounds good! Please collect a Reviewed-by from one or both of them.
Ok.
thanks,
- Joel
next prev parent reply other threads:[~2022-04-14 19:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 21:07 [PATCH RFC] rcu/nocb: Provide default all-CPUs mask for RCU_NOCB_CPU=y Joel Fernandes
2022-04-08 14:22 ` Paul E. McKenney
2022-04-08 14:52 ` Joel Fernandes
2022-04-08 15:50 ` Paul E. McKenney
2022-04-08 17:20 ` Joel Fernandes
2022-04-08 17:49 ` Paul E. McKenney
2022-04-08 18:22 ` Joel Fernandes
2022-04-08 18:23 ` Joel Fernandes
2022-04-08 20:54 ` Paul E. McKenney
2022-04-08 21:46 ` Uladzislau Rezki
2022-04-11 14:08 ` Paul E. McKenney
2022-04-11 15:20 ` Uladzislau Rezki
2022-04-11 15:17 ` Joel Fernandes
2022-04-11 15:41 ` Paul E. McKenney
2022-04-14 19:19 ` Joel Fernandes [this message]
2022-04-14 19:42 ` Paul E. McKenney
2022-04-14 19:49 ` Joel Fernandes
2022-04-14 19:51 ` Joel Fernandes
2022-04-14 21:10 ` Paul E. McKenney
2022-04-14 21:09 ` Paul E. McKenney
2022-04-14 21:14 ` Joel Fernandes
2022-04-14 21:31 ` Paul E. McKenney
2022-04-14 21:38 ` Joel Fernandes
2022-04-14 22:37 ` Paul E. McKenney
2022-04-20 20:36 ` Steven Rostedt
2022-04-11 13:49 ` Uladzislau Rezki
2022-04-11 15:17 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ylhz1LOIf+JyjH7n@google.com \
--to=joel@joelfernandes.org \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox