The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Ren Yu <renyu@nfschina.com>
Cc: aaro.koskinen@iki.fi, linux@armlinux.org.uk,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, liqiong@nfschina.com,
	yuzhe@nfschina.com, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] plat-omap: check return value of ioremap()
Date: Tue, 26 Apr 2022 11:05:23 +0300	[thread overview]
Message-ID: <Ymenw5/haMIjFlCP@atomide.com> (raw)
In-Reply-To: <20220425110845.415439-1-renyu@nfschina.com>

Hi,

* Ren Yu <renyu@nfschina.com> [220425 11:08]:
> When ioremap() failed,return err

This file is no longer being used and getting removed in Linux next.
See commit 7058e68c2fed ("ARM: omap: remove debug-leds driver").

Thanks,

Tony

> Signed-off-by: Ren Yu <renyu@nfschina.com>
> ---
>  arch/arm/plat-omap/debug-leds.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/plat-omap/debug-leds.c b/arch/arm/plat-omap/debug-leds.c
> index 2b698d074874..bf5034e10f6e 100644
> --- a/arch/arm/plat-omap/debug-leds.c
> +++ b/arch/arm/plat-omap/debug-leds.c
> @@ -109,6 +109,9 @@ static int fpga_probe(struct platform_device *pdev)
>  		return -ENODEV;
>  
>  	fpga = ioremap(iomem->start, resource_size(iomem));
> +	if (!fpga)
> +		return -ENOMEM;
> +
>  	writew_relaxed(0xff, &fpga->leds);
>  
>  	for (i = 0; i < ARRAY_SIZE(dbg_leds); i++) {
> -- 
> 2.25.1
> 

      reply	other threads:[~2022-04-26  8:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 11:08 [PATCH] plat-omap: check return value of ioremap() Ren Yu
2022-04-26  8:05 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ymenw5/haMIjFlCP@atomide.com \
    --to=tony@atomide.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=liqiong@nfschina.com \
    --cc=renyu@nfschina.com \
    --cc=yuzhe@nfschina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox