From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] random: move initialization out of reseeding hot path
Date: Fri, 13 May 2022 12:21:34 +0200 [thread overview]
Message-ID: <Yn4xLowv+farg814@zx2c4.com> (raw)
In-Reply-To: <Yn35k+yyrvgAt3tb@owl.dominikbrodowski.net>
Hi Dominik,
On Fri, May 13, 2022 at 08:24:19AM +0200, Dominik Brodowski wrote:
> > - if (!crng_ready()) {
> > - crng_init = CRNG_READY;
> > - finalize_init = true;
> > - }
> > + crng_init = CRNG_READY;
>
> Why unconditionally
To avoid a useless branch.
> (you revert that bit in the static branch patch and make
> it conditional again; so I see no reason for that here)?
With the static branch patch, I can totally remove the branch and the
store all together, so we get the best of both worlds.
Jason
next prev parent reply other threads:[~2022-05-13 10:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 12:14 [PATCH 1/2] random: avoid init'ing twice in credit race Jason A. Donenfeld
2022-05-09 12:14 ` [PATCH 2/2] random: move initialization out of reseeding hot path Jason A. Donenfeld
2022-05-13 6:24 ` Dominik Brodowski
2022-05-13 10:21 ` Jason A. Donenfeld [this message]
2022-05-13 11:38 ` David Laight
2022-05-13 12:02 ` Jason A. Donenfeld
2022-05-13 12:05 ` [PATCH v2] " Jason A. Donenfeld
2022-05-13 6:23 ` [PATCH 1/2] random: avoid init'ing twice in credit race Dominik Brodowski
2022-05-13 10:23 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yn4xLowv+farg814@zx2c4.com \
--to=jason@zx2c4.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox