* [PATCH] media: lirc: revert removal of unused feature flags
@ 2022-05-25 13:08 Sean Young
2022-05-25 16:53 ` Linus Torvalds
0 siblings, 1 reply; 3+ messages in thread
From: Sean Young @ 2022-05-25 13:08 UTC (permalink / raw)
To: Jiri Slaby
Cc: Mauro Carvalho Chehab, Linus Torvalds, Greg Kroah-Hartman,
Andrew Morton, Linux Media Mailing List,
Linux Kernel Mailing List
commit b2a90f4fcb14 ("media: lirc: remove unused lirc features") removed
feature flags which were never implemented, but they are still used by
the lirc daemon went built from source.
Reinstate these symbols in order not to break the lirc build.
Cc: Jiri Slaby <jirislaby@kernel.org>
Link: https://lkml.org/lkml/2022/5/25/58
Fixes: b2a90f4fcb14 ("media: lirc: remove unused lirc features")
Signed-off-by: Sean Young <sean@mess.org>
---
include/uapi/linux/lirc.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/uapi/linux/lirc.h b/include/uapi/linux/lirc.h
index 23b0f2c8ba81..8d7ca7c6af42 100644
--- a/include/uapi/linux/lirc.h
+++ b/include/uapi/linux/lirc.h
@@ -84,6 +84,13 @@
#define LIRC_CAN_SEND(x) ((x)&LIRC_CAN_SEND_MASK)
#define LIRC_CAN_REC(x) ((x)&LIRC_CAN_REC_MASK)
+/*
+ * Unused features. These features were never implemented, in tree or
+ * out of tree. These definitions are here so not to break the lircd build.
+ */
+#define LIRC_CAN_SET_REC_FILTER 0
+#define LIRC_CAN_NOTIFY_DECODE 0
+
/*** IOCTL commands for lirc driver ***/
#define LIRC_GET_FEATURES _IOR('i', 0x00000000, __u32)
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] media: lirc: revert removal of unused feature flags
2022-05-25 13:08 [PATCH] media: lirc: revert removal of unused feature flags Sean Young
@ 2022-05-25 16:53 ` Linus Torvalds
2022-05-26 9:01 ` Jiri Slaby
0 siblings, 1 reply; 3+ messages in thread
From: Linus Torvalds @ 2022-05-25 16:53 UTC (permalink / raw)
To: Sean Young
Cc: Jiri Slaby, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Andrew Morton, Linux Media Mailing List,
Linux Kernel Mailing List
On Wed, May 25, 2022 at 6:08 AM Sean Young <sean@mess.org> wrote:
>
> commit b2a90f4fcb14 ("media: lirc: remove unused lirc features") removed
> feature flags which were never implemented, but they are still used by
> the lirc daemon went built from source.
>
> Reinstate these symbols in order not to break the lirc build.
Applied directly to my tree. Thanks,
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: lirc: revert removal of unused feature flags
2022-05-25 16:53 ` Linus Torvalds
@ 2022-05-26 9:01 ` Jiri Slaby
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Slaby @ 2022-05-26 9:01 UTC (permalink / raw)
To: Linus Torvalds, Sean Young
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, Andrew Morton,
Linux Media Mailing List, Linux Kernel Mailing List
On 25. 05. 22, 18:53, Linus Torvalds wrote:
> On Wed, May 25, 2022 at 6:08 AM Sean Young <sean@mess.org> wrote:
>>
>> commit b2a90f4fcb14 ("media: lirc: remove unused lirc features") removed
>> feature flags which were never implemented, but they are still used by
>> the lirc daemon went built from source.
>>
>> Reinstate these symbols in order not to break the lirc build.
>
> Applied directly to my tree. Thanks,
Works for me, thanks.
--
js
suse labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-26 9:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-25 13:08 [PATCH] media: lirc: revert removal of unused feature flags Sean Young
2022-05-25 16:53 ` Linus Torvalds
2022-05-26 9:01 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox