From: Mark Brown <broonie@kernel.org>
To: Xiaohui Zhang <xiaohuizhang@ruc.edu.cn>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] spi: fix use after free in of_spi_notify
Date: Tue, 7 Jun 2022 17:20:39 +0100 [thread overview]
Message-ID: <Yp961zPy064+ouF0@sirena.org.uk> (raw)
In-Reply-To: <20220607155233.27235-1-xiaohuizhang@ruc.edu.cn>
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
On Tue, Jun 07, 2022 at 11:52:33PM +0800, Xiaohui Zhang wrote:
> We can't use "ctlr->dev" after it has been freed.
> spi = of_register_spi_device(ctlr, rd->dn);
> - put_device(&ctlr->dev);
>
> if (IS_ERR(spi)) {
> pr_err("%s: failed to create for '%pOF'\n",
> __func__, rd->dn);
> + put_device(&ctlr->dev);
> of_node_clear_flag(rd->dn, OF_POPULATED);
> return notifier_from_errno(PTR_ERR(spi));
> }
> + put_device(&ctlr->dev);
> break;
Could you be more explicit about where the problematic use of ctlr->dev
is please?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-06-07 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 15:52 [PATCH 1/1] spi: fix use after free in of_spi_notify Xiaohui Zhang
2022-06-07 16:20 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp961zPy064+ouF0@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=xiaohuizhang@ruc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox