From: Tony Lindgren <tony@atomide.com>
To: Liang He <windhl@126.com>
Cc: linux@armlinux.org.uk, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: mach-omap2: omap4-common: Fix refcount leak bug
Date: Tue, 28 Jun 2022 07:38:49 +0300 [thread overview]
Message-ID: <YrqF2bXbxcYFsUy6@atomide.com> (raw)
In-Reply-To: <20220617035548.4003393-1-windhl@126.com>
* Liang He <windhl@126.com> [220617 06:51]:
> In omap4_sram_init(), of_find_compatible_node() will return a node
> pointer with refcount incremented. We should use of_node_put() when
> it is not used anymore.
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
> arch/arm/mach-omap2/omap4-common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c
> index 6d1eb4eefefe..e981bf57e64f 100644
> --- a/arch/arm/mach-omap2/omap4-common.c
> +++ b/arch/arm/mach-omap2/omap4-common.c
> @@ -135,6 +135,7 @@ static int __init omap4_sram_init(void)
> pr_warn("%s:Unable to allocate sram needed to handle errata I688\n",
> __func__);
> sram_pool = of_gen_pool_get(np, "sram", 0);
> + of_node_put(np);
> if (!sram_pool)
> pr_warn("%s:Unable to get sram pool needed to handle errata I688\n",
> __func__);
Here too sram_pool is used aftger of_node_put().
Regards,
Tony
next prev parent reply other threads:[~2022-06-28 4:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 3:55 [PATCH] arm: mach-omap2: omap4-common: Fix refcount leak bug Liang He
2022-06-28 4:38 ` Tony Lindgren [this message]
2022-06-28 5:52 ` Liang He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrqF2bXbxcYFsUy6@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox