* [PATCH] arm: mach-omap2: display: Fix refcount leak bug
@ 2022-06-17 14:58 Liang He
2022-06-28 4:41 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Liang He @ 2022-06-17 14:58 UTC (permalink / raw)
To: tony, linux; +Cc: windhl, linux-arm-kernel, linux-omap, linux-kernel
In omapdss_init_fbdev(), of_find_node_by_name() will return a node
pointer with refcount incremented. We should use of_node_put() when
it is not used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
arch/arm/mach-omap2/display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c
index 21413a9b7b6c..eb09a25e3b45 100644
--- a/arch/arm/mach-omap2/display.c
+++ b/arch/arm/mach-omap2/display.c
@@ -211,6 +211,7 @@ static int __init omapdss_init_fbdev(void)
node = of_find_node_by_name(NULL, "omap4_padconf_global");
if (node)
omap4_dsi_mux_syscon = syscon_node_to_regmap(node);
+ of_node_put(node);
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm: mach-omap2: display: Fix refcount leak bug
2022-06-17 14:58 [PATCH] arm: mach-omap2: display: Fix refcount leak bug Liang He
@ 2022-06-28 4:41 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2022-06-28 4:41 UTC (permalink / raw)
To: Liang He; +Cc: linux, linux-arm-kernel, linux-omap, linux-kernel
* Liang He <windhl@126.com> [220617 17:53]:
> In omapdss_init_fbdev(), of_find_node_by_name() will return a node
> pointer with refcount incremented. We should use of_node_put() when
> it is not used anymore.
Thanks applying into omap-for-v5.20/soc.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-28 4:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-17 14:58 [PATCH] arm: mach-omap2: display: Fix refcount leak bug Liang He
2022-06-28 4:41 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox