From: Vinod Koul <vkoul@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Amireddy Mallikarjuna reddy
<mallikarjunax.reddy@linux.intel.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmaengine: lgm: Fix an error handling path in intel_ldma_probe()
Date: Wed, 6 Jul 2022 10:53:33 +0530 [thread overview]
Message-ID: <YsUcVXhGvLVb7VOa@matsya> (raw)
In-Reply-To: <18504549bc4d2b62a72a02cb22a2e4d8e6a58720.1653241224.git.christophe.jaillet@wanadoo.fr>
On 22-05-22, 19:41, Christophe JAILLET wrote:
> ldma_clk_disable() calls both:
> clk_disable_unprepare(d->core_clk);
> reset_control_assert(d->rst);
>
> So, should devm_reset_control_get_optional() fail, core_clk should not
> be prepare_enable'd before it, otherwise it will never be
> disable_unprepare'd.
>
> Reorder the code to handle the error handling path as expected.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2022-07-06 5:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 17:41 [PATCH] dmaengine: lgm: Fix an error handling path in intel_ldma_probe() Christophe JAILLET
2022-07-06 5:23 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsUcVXhGvLVb7VOa@matsya \
--to=vkoul@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunax.reddy@linux.intel.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox