* [PATCH linux-next] eeprom: at24:using the pm_runtime_resume_and_get to simplify the code
@ 2022-08-03 6:16 cgel.zte
2022-08-03 6:22 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-08-03 6:16 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh, linux-i2c, ye xingchen, Zeal Robot
From: ye xingchen <ye.xingchen@zte.com.cn>
Using pm_runtime_resume_and_get() to instade of pm_runtime_get_sync
and pm_runtime_put_noidle.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/misc/eeprom/at24.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 633e1cf08d6e..f354b79619d8 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -431,9 +431,8 @@ static int at24_read(void *priv, unsigned int off, void *val, size_t count)
if (off + count > at24->byte_len)
return -EINVAL;
- ret = pm_runtime_get_sync(dev);
+ ret = pm_runtime_resume_and_get(dev);
if (ret < 0) {
- pm_runtime_put_noidle(dev);
return ret;
}
@@ -478,9 +477,8 @@ static int at24_write(void *priv, unsigned int off, void *val, size_t count)
if (off + count > at24->byte_len)
return -EINVAL;
- ret = pm_runtime_get_sync(dev);
+ ret = pm_runtime_resume_and_get(dev);
if (ret < 0) {
- pm_runtime_put_noidle(dev);
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH linux-next] eeprom: at24:using the pm_runtime_resume_and_get to simplify the code
2022-08-03 6:16 [PATCH linux-next] eeprom: at24:using the pm_runtime_resume_and_get to simplify the code cgel.zte
@ 2022-08-03 6:22 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2022-08-03 6:22 UTC (permalink / raw)
To: cgel.zte; +Cc: linux-kernel, linux-i2c, ye xingchen, Zeal Robot
On Wed, Aug 03, 2022 at 06:16:18AM +0000, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Using pm_runtime_resume_and_get() to instade of pm_runtime_get_sync
> and pm_runtime_put_noidle.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/misc/eeprom/at24.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
> index 633e1cf08d6e..f354b79619d8 100644
> --- a/drivers/misc/eeprom/at24.c
> +++ b/drivers/misc/eeprom/at24.c
> @@ -431,9 +431,8 @@ static int at24_read(void *priv, unsigned int off, void *val, size_t count)
> if (off + count > at24->byte_len)
> return -EINVAL;
>
> - ret = pm_runtime_get_sync(dev);
> + ret = pm_runtime_resume_and_get(dev);
> if (ret < 0) {
> - pm_runtime_put_noidle(dev);
> return ret;
> }
>
> @@ -478,9 +477,8 @@ static int at24_write(void *priv, unsigned int off, void *val, size_t count)
> if (off + count > at24->byte_len)
> return -EINVAL;
>
> - ret = pm_runtime_get_sync(dev);
> + ret = pm_runtime_resume_and_get(dev);
> if (ret < 0) {
> - pm_runtime_put_noidle(dev);
> return ret;
> }
>
> --
> 2.25.1
Again, please read:
https://lore.kernel.org/r/YujeLEMsIrVD2tGn@kroah.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-03 6:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-03 6:16 [PATCH linux-next] eeprom: at24:using the pm_runtime_resume_and_get to simplify the code cgel.zte
2022-08-03 6:22 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox