[PATCH] usb/serial:Modify the return value to void

[PATCH] usb/serial:Modify the return value to void

[Zhou jie]

Modify the return value to void,The return value is not used elsewhere.

Signed-off-by: Zhou jie <zhoujie@nfschina.com>
---
 drivers/usb/serial/mos7720.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
index 1e12b5f30dcc..ddb3a2d0f819 100644
--- a/drivers/usb/serial/mos7720.c
+++ b/drivers/usb/serial/mos7720.c
@@ -239,13 +239,12 @@ static int read_mos_reg(struct usb_serial *serial, unsigned int serial_portnum,
 
 #ifdef CONFIG_USB_SERIAL_MOS7715_PARPORT
 
-static inline int mos7715_change_mode(struct mos7715_parport *mos_parport,
+static inline void mos7715_change_mode(struct mos7715_parport *mos_parport,
 				      enum mos7715_pp_modes mode)
 {
 	mos_parport->shadowECR = mode;
 	write_mos_reg(mos_parport->serial, dummy, MOS7720_ECR,
 		      mos_parport->shadowECR);
-	return 0;
 }
 
 static void destroy_mos_parport(struct kref *kref)
-- 
2.18.2

Re: [PATCH] usb/serial:Modify the return value to void

[Greg KH]

On Thu, Aug 11, 2022 at 03:03:58PM +0800, Zhou jie wrote:
> Modify the return value to void,The return value is not used elsewhere.
> 
> Signed-off-by: Zhou jie <zhoujie@nfschina.com>
> ---
>  drivers/usb/serial/mos7720.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
> index 1e12b5f30dcc..ddb3a2d0f819 100644
> --- a/drivers/usb/serial/mos7720.c
> +++ b/drivers/usb/serial/mos7720.c
> @@ -239,13 +239,12 @@ static int read_mos_reg(struct usb_serial *serial, unsigned int serial_portnum,
>  
>  #ifdef CONFIG_USB_SERIAL_MOS7715_PARPORT
>  
> -static inline int mos7715_change_mode(struct mos7715_parport *mos_parport,
> +static inline void mos7715_change_mode(struct mos7715_parport *mos_parport,
>  				      enum mos7715_pp_modes mode)
>  {
>  	mos_parport->shadowECR = mode;
>  	write_mos_reg(mos_parport->serial, dummy, MOS7720_ECR,
>  		      mos_parport->shadowECR);
> -	return 0;

Why not check the return value of write_mos_reg() and properly handle
the error that can give you instead of ignoring it?

thanks,

greg k-h

Re: [PATCH] usb/serial:Modify the return value to void

[Zhou jie]

v2:
  Modifying function return value type does not work

[PATCH v2] usb/serial:Repair function return value

[Zhou jie]

Repair function return value,The previous return value did not work.

v2:
  Modifying function return value type does not work.

Signed-off-by: Zhou jie <zhoujie@nfschina.com>
---
 drivers/usb/serial/mos7720.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
index 1e12b5f30dcc..215b1c87fa07 100644
--- a/drivers/usb/serial/mos7720.c
+++ b/drivers/usb/serial/mos7720.c
@@ -243,9 +243,8 @@ static inline int mos7715_change_mode(struct mos7715_parport *mos_parport,
 				      enum mos7715_pp_modes mode)
 {
 	mos_parport->shadowECR = mode;
-	write_mos_reg(mos_parport->serial, dummy, MOS7720_ECR,
+	return write_mos_reg(mos_parport->serial, dummy, MOS7720_ECR,
 		      mos_parport->shadowECR);
-	return 0;
 }
 
 static void destroy_mos_parport(struct kref *kref)
-- 
2.18.2

Re: [PATCH v2] usb/serial:Repair function return value

[Greg KH]

On Thu, Aug 11, 2022 at 04:42:37PM +0800, Zhou jie wrote:
> Repair function return value,The previous return value did not work.
> 
> v2:
>   Modifying function return value type does not work.

Please put this below the --- line as the documentation asks for.

> 
> Signed-off-by: Zhou jie <zhoujie@nfschina.com>
> ---
>  drivers/usb/serial/mos7720.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
> index 1e12b5f30dcc..215b1c87fa07 100644
> --- a/drivers/usb/serial/mos7720.c
> +++ b/drivers/usb/serial/mos7720.c
> @@ -243,9 +243,8 @@ static inline int mos7715_change_mode(struct mos7715_parport *mos_parport,
>  				      enum mos7715_pp_modes mode)
>  {
>  	mos_parport->shadowECR = mode;
> -	write_mos_reg(mos_parport->serial, dummy, MOS7720_ECR,
> +	return write_mos_reg(mos_parport->serial, dummy, MOS7720_ECR,
>  		      mos_parport->shadowECR);
> -	return 0;

Are you sure that this change does what you think it does?

Hint, what does write_mos_reg() return if all goes well?

Also the indentation of the second line is now incorrect.

This is going to take more work to get correct, please take your time
and think about it and test your changes before resending.

thanks,

greg k-h

Re: [PATCH v2] usb/serial:Repair function return value

[Zhou jie]

The return value processing has been done in the write_mos_reg() function, no additional operations are required here, just return the result directly.
Also the indentation of the second line is now incorrect? What's wrong?

Re: [PATCH v2] usb/serial:Repair function return value

[Greg KH]

On Thu, Aug 11, 2022 at 10:51:22AM +0200, Greg KH wrote:
> On Thu, Aug 11, 2022 at 04:42:37PM +0800, Zhou jie wrote:
> > Repair function return value,The previous return value did not work.
> > 
> > v2:
> >   Modifying function return value type does not work.
> 
> Please put this below the --- line as the documentation asks for.

Also, do not cc: email addresses that do not accept external emails,
that just causes bounces for everyone else when they respond to your
email :(

thanks,

greg k-h

Re: [PATCH v2] usb/serial:Repair function return value

[Greg KH]

On Thu, Aug 11, 2022 at 05:05:00PM +0800, Zhou jie wrote:
> 
> The return value processing has been done in the write_mos_reg() function, no additional operations are required here, just return the result directly.
> Also the indentation of the second line is now incorrect? What's wrong?
> 

I have no context for this email and do not understand it at all, sorry
:(