From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Dmitry Rokosov <DDRokosov@sberdevices.ru>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v1 2/3] regmap: trace: Remove explicit castings
Date: Thu, 1 Sep 2022 14:31:53 +0100 [thread overview]
Message-ID: <YxC0SYShl14TSw2o@sirena.org.uk> (raw)
In-Reply-To: <20220901132336.33234-2-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
On Thu, Sep 01, 2022 at 04:23:35PM +0300, Andy Shevchenko wrote:
> There is no need to have explicit castings to the same type the
> variables are of. Remove the explicit castings.
IIRC this was an idiom that the trace code was using for some deep magic
reason to do with some fiddly preprocessor stuff.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-09-01 13:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 13:23 [PATCH v1 1/3] regmap: trace: Remove useless check for NULL for bulk ops Andy Shevchenko
2022-09-01 13:23 ` [PATCH v1 2/3] regmap: trace: Remove explicit castings Andy Shevchenko
2022-09-01 13:31 ` Mark Brown [this message]
2022-09-01 14:18 ` Andy Shevchenko
2022-09-01 14:46 ` Steven Rostedt
2022-09-01 14:50 ` Mark Brown
2022-09-01 15:28 ` Steven Rostedt
2022-09-01 22:22 ` Dmitry Rokosov
2022-09-01 13:23 ` [PATCH v1 3/3] regmap: trace: Remove unneeded blank lines Andy Shevchenko
2022-09-01 22:22 ` Dmitry Rokosov
2022-09-01 22:20 ` [PATCH v1 1/3] regmap: trace: Remove useless check for NULL for bulk ops Dmitry Rokosov
2022-09-05 17:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxC0SYShl14TSw2o@sirena.org.uk \
--to=broonie@kernel.org \
--cc=DDRokosov@sberdevices.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox