From: Mark Brown <broonie@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Dmitry Rokosov <DDRokosov@sberdevices.ru>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v1 2/3] regmap: trace: Remove explicit castings
Date: Thu, 1 Sep 2022 15:50:17 +0100 [thread overview]
Message-ID: <YxDGqdzv3uvEgALv@sirena.org.uk> (raw)
In-Reply-To: <20220901104601.01773fb8@gandalf.local.home>
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
On Thu, Sep 01, 2022 at 10:46:01AM -0400, Steven Rostedt wrote:
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > Perhaps that (dark) magic disappeared a long time ago since in my
> > practice of adding trace events this is the first (and probably
> > oldest) one which has these castings. Perhaps Steven can shed a light.
> There was no dark magic for those castings. The trace events never needed
> them. It was added from the original commit:
> fb2736bbaee0e ("regmap: Add basic tracepoints")
Right, they were added in the original commit because as far as I could
tell at that time they were needed for things to build (or possibly
build cleanly, it's been a while).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-09-01 14:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 13:23 [PATCH v1 1/3] regmap: trace: Remove useless check for NULL for bulk ops Andy Shevchenko
2022-09-01 13:23 ` [PATCH v1 2/3] regmap: trace: Remove explicit castings Andy Shevchenko
2022-09-01 13:31 ` Mark Brown
2022-09-01 14:18 ` Andy Shevchenko
2022-09-01 14:46 ` Steven Rostedt
2022-09-01 14:50 ` Mark Brown [this message]
2022-09-01 15:28 ` Steven Rostedt
2022-09-01 22:22 ` Dmitry Rokosov
2022-09-01 13:23 ` [PATCH v1 3/3] regmap: trace: Remove unneeded blank lines Andy Shevchenko
2022-09-01 22:22 ` Dmitry Rokosov
2022-09-01 22:20 ` [PATCH v1 1/3] regmap: trace: Remove useless check for NULL for bulk ops Dmitry Rokosov
2022-09-05 17:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxDGqdzv3uvEgALv@sirena.org.uk \
--to=broonie@kernel.org \
--cc=DDRokosov@sberdevices.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox