* [PATCH -next] mfd: ocelot-spi: Add missing MODULE_DEVICE_TABLE
@ 2022-09-22 10:37 Yang Yingliang
2022-09-22 15:06 ` Colin Foster
2022-09-28 15:10 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2022-09-22 10:37 UTC (permalink / raw)
To: linux-kernel; +Cc: colin.foster, lee
This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.
Fixes: f3e893626abe ("mfd: ocelot: Add support for the vsc7512 chip via spi")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/mfd/ocelot-spi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/ocelot-spi.c b/drivers/mfd/ocelot-spi.c
index 0f097f4829d1..2ecd271de2fb 100644
--- a/drivers/mfd/ocelot-spi.c
+++ b/drivers/mfd/ocelot-spi.c
@@ -276,6 +276,7 @@ static const struct spi_device_id ocelot_spi_ids[] = {
{ "vsc7512", 0 },
{ }
};
+MODULE_DEVICE_TABLE(spi, ocelot_spi_ids);
static const struct of_device_id ocelot_spi_of_match[] = {
{ .compatible = "mscc,vsc7512" },
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] mfd: ocelot-spi: Add missing MODULE_DEVICE_TABLE
2022-09-22 10:37 [PATCH -next] mfd: ocelot-spi: Add missing MODULE_DEVICE_TABLE Yang Yingliang
@ 2022-09-22 15:06 ` Colin Foster
2022-09-28 15:10 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Colin Foster @ 2022-09-22 15:06 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, lee
Hi Yang,
On Thu, Sep 22, 2022 at 06:37:03PM +0800, Yang Yingliang wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Fixes: f3e893626abe ("mfd: ocelot: Add support for the vsc7512 chip via spi")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/mfd/ocelot-spi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/ocelot-spi.c b/drivers/mfd/ocelot-spi.c
> index 0f097f4829d1..2ecd271de2fb 100644
> --- a/drivers/mfd/ocelot-spi.c
> +++ b/drivers/mfd/ocelot-spi.c
> @@ -276,6 +276,7 @@ static const struct spi_device_id ocelot_spi_ids[] = {
> { "vsc7512", 0 },
> { }
> };
> +MODULE_DEVICE_TABLE(spi, ocelot_spi_ids);
>
> static const struct of_device_id ocelot_spi_of_match[] = {
> { .compatible = "mscc,vsc7512" },
> --
> 2.25.1
>
Good catch. I just tested running ocelot-soc as a module and it worked
without your patch. Do you know how I can test the case where it fails?
Thanks
Colin Foster
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] mfd: ocelot-spi: Add missing MODULE_DEVICE_TABLE
2022-09-22 10:37 [PATCH -next] mfd: ocelot-spi: Add missing MODULE_DEVICE_TABLE Yang Yingliang
2022-09-22 15:06 ` Colin Foster
@ 2022-09-28 15:10 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2022-09-28 15:10 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, colin.foster
On Thu, 22 Sep 2022, Yang Yingliang wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Fixes: f3e893626abe ("mfd: ocelot: Add support for the vsc7512 chip via spi")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/mfd/ocelot-spi.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-28 15:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-22 10:37 [PATCH -next] mfd: ocelot-spi: Add missing MODULE_DEVICE_TABLE Yang Yingliang
2022-09-22 15:06 ` Colin Foster
2022-09-28 15:10 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox