From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v1 1/1] media: i2c: ds90ub9x3: Remove unneeded of_gpio_n_cells assignment
Date: Thu, 3 Apr 2025 13:58:10 +0300 [thread overview]
Message-ID: <Z-5pwpoYEKKmtmPA@smile.fi.intel.com> (raw)
In-Reply-To: <c7fd0bd4-4fc8-43f0-b980-b49472e76445@ideasonboard.com>
On Thu, Apr 03, 2025 at 11:07:40AM +0300, Tomi Valkeinen wrote:
> On 31/03/2025 10:02, Andy Shevchenko wrote:
> > The default for of_gpio_n_cells is 2, no need to assign the same
> > in the user.
>
> Where is this documented? I'm also having trouble finding the
> implementation.
The idea was introduced back in 391c970c0dd1 ("of/gpio: add default of_xlate
function if device has a node pointer"). But now I realised that it was never
assumed that default is 2 for the cases when the ->of_xlate() explicitly
provided. So, this is wrong patch, thanks for the review!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-03 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 7:02 [PATCH v1 1/1] media: i2c: ds90ub9x3: Remove unneeded of_gpio_n_cells assignment Andy Shevchenko
2025-04-03 8:07 ` Tomi Valkeinen
2025-04-03 10:58 ` Andy Shevchenko [this message]
2025-05-05 8:17 ` Sakari Ailus
2025-05-05 14:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-5pwpoYEKKmtmPA@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox