From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v1 1/1] media: i2c: ds90ub9x3: Remove unneeded of_gpio_n_cells assignment
Date: Mon, 5 May 2025 17:38:37 +0300 [thread overview]
Message-ID: <aBjNbVPTw4hyuKgR@smile.fi.intel.com> (raw)
In-Reply-To: <aBh0K2YGhgxk6ipv@valkosipuli.retiisi.eu>
On Mon, May 05, 2025 at 08:17:47AM +0000, Sakari Ailus wrote:
> On Thu, Apr 03, 2025 at 01:58:10PM +0300, Andy Shevchenko wrote:
> > On Thu, Apr 03, 2025 at 11:07:40AM +0300, Tomi Valkeinen wrote:
> > > On 31/03/2025 10:02, Andy Shevchenko wrote:
> > > > The default for of_gpio_n_cells is 2, no need to assign the same
> > > > in the user.
> > >
> > > Where is this documented? I'm also having trouble finding the
> > > implementation.
> >
> > The idea was introduced back in 391c970c0dd1 ("of/gpio: add default of_xlate
> > function if device has a node pointer"). But now I realised that it was never
> > assumed that default is 2 for the cases when the ->of_xlate() explicitly
> > provided. So, this is wrong patch, thanks for the review!
>
> Does the same conclusion apply to the similar max96717 patch as well?
If you are referring to
20250331070152.3985520-1-andriy.shevchenko@linux.intel.com
(and why not replying there?), then no, that change is correct.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-05-05 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 7:02 [PATCH v1 1/1] media: i2c: ds90ub9x3: Remove unneeded of_gpio_n_cells assignment Andy Shevchenko
2025-04-03 8:07 ` Tomi Valkeinen
2025-04-03 10:58 ` Andy Shevchenko
2025-05-05 8:17 ` Sakari Ailus
2025-05-05 14:38 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBjNbVPTw4hyuKgR@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox