From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: liujing <liujing@cmss.chinamobile.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
masahiroy@kernel.org, nicolas@fjasle.eu,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] speakup: Fix the wrong format specifier
Date: Wed, 4 Dec 2024 23:34:20 +0100 [thread overview]
Message-ID: <Z1DY7PPuTA0y86ey@begin> (raw)
In-Reply-To: <20241204150303.8219-1-liujing@cmss.chinamobile.com>
liujing, le mer. 04 déc. 2024 23:03:03 +0800, a ecrit:
> Make a minor change to eliminate a static checker warning. The type
> of '(unsigned int)kp[i]' is unsigned int, so the correct format specifier should be
> %u instead of %d.
>
> Signed-off-by: liujing <liujing@cmss.chinamobile.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Thanks!
> diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
> index 0882bab10fb8..9bd78e1f023b 100644
> --- a/drivers/accessibility/speakup/genmap.c
> +++ b/drivers/accessibility/speakup/genmap.c
> @@ -153,7 +153,7 @@ main(int argc, char *argv[])
> continue;
> printf("\n\t%d,", lc);
> for (i = 0; i < max_states; i++)
> - printf(" %d,", (unsigned int)kp[i]);
> + printf(" %u,", (unsigned int)kp[i]);
> }
> printf("\n\t0, %d\n", map_ver);
>
> --
> 2.27.0
prev parent reply other threads:[~2024-12-04 22:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 15:03 [PATCH] speakup: Fix the wrong format specifier liujing
2024-12-04 22:34 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1DY7PPuTA0y86ey@begin \
--to=samuel.thibault@ens-lyon.org \
--cc=chris@the-brannons.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=liujing@cmss.chinamobile.com \
--cc=masahiroy@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox