* [PATCH] speakup: Fix the wrong format specifier
@ 2024-12-04 15:03 liujing
2024-12-04 22:34 ` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: liujing @ 2024-12-04 15:03 UTC (permalink / raw)
To: w.d.hubbs, chris, kirk, samuel.thibault, masahiroy
Cc: nicolas, speakup, linux-kernel, liujing
Make a minor change to eliminate a static checker warning. The type
of '(unsigned int)kp[i]' is unsigned int, so the correct format specifier should be
%u instead of %d.
Signed-off-by: liujing <liujing@cmss.chinamobile.com>
diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
index 0882bab10fb8..9bd78e1f023b 100644
--- a/drivers/accessibility/speakup/genmap.c
+++ b/drivers/accessibility/speakup/genmap.c
@@ -153,7 +153,7 @@ main(int argc, char *argv[])
continue;
printf("\n\t%d,", lc);
for (i = 0; i < max_states; i++)
- printf(" %d,", (unsigned int)kp[i]);
+ printf(" %u,", (unsigned int)kp[i]);
}
printf("\n\t0, %d\n", map_ver);
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] speakup: Fix the wrong format specifier
2024-12-04 15:03 [PATCH] speakup: Fix the wrong format specifier liujing
@ 2024-12-04 22:34 ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2024-12-04 22:34 UTC (permalink / raw)
To: liujing; +Cc: w.d.hubbs, chris, kirk, masahiroy, nicolas, speakup, linux-kernel
liujing, le mer. 04 déc. 2024 23:03:03 +0800, a ecrit:
> Make a minor change to eliminate a static checker warning. The type
> of '(unsigned int)kp[i]' is unsigned int, so the correct format specifier should be
> %u instead of %d.
>
> Signed-off-by: liujing <liujing@cmss.chinamobile.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Thanks!
> diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
> index 0882bab10fb8..9bd78e1f023b 100644
> --- a/drivers/accessibility/speakup/genmap.c
> +++ b/drivers/accessibility/speakup/genmap.c
> @@ -153,7 +153,7 @@ main(int argc, char *argv[])
> continue;
> printf("\n\t%d,", lc);
> for (i = 0; i < max_states; i++)
> - printf(" %d,", (unsigned int)kp[i]);
> + printf(" %u,", (unsigned int)kp[i]);
> }
> printf("\n\t0, %d\n", map_ver);
>
> --
> 2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-04 22:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-04 15:03 [PATCH] speakup: Fix the wrong format specifier liujing
2024-12-04 22:34 ` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox