* [PATCH v1 1/2] perf hwmon_pmu: Use openat rather than dup to refresh directory
@ 2024-12-06 4:23 Ian Rogers
2024-12-06 4:23 ` [PATCH v1 2/2] perf test hwmon_pmu: Fix event file location Ian Rogers
2024-12-11 17:23 ` [PATCH v1 1/2] perf hwmon_pmu: Use openat rather than dup to refresh directory Namhyung Kim
0 siblings, 2 replies; 6+ messages in thread
From: Ian Rogers @ 2024-12-06 4:23 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Ian Rogers, Adrian Hunter, Kan Liang, linux-perf-users,
linux-kernel
The hwmon PMU test will make a temp directory, open the directory with
O_DIRECTORY then fill it with contents. As the open is before the
filling the contents the later fdopendir may reflect the initial empty
state, meaning no events are seen. Change to re-open the directory,
rather than dup the fd, so the latest contents are seen.
Minor tweaks/additions to debug messages.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/hwmon_pmu.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/hwmon_pmu.c b/tools/perf/util/hwmon_pmu.c
index e61429b38ba7..4acb9bb19b84 100644
--- a/tools/perf/util/hwmon_pmu.c
+++ b/tools/perf/util/hwmon_pmu.c
@@ -258,8 +258,12 @@ static int hwmon_pmu__read_events(struct hwmon_pmu *pmu)
if (pmu->pmu.sysfs_aliases_loaded)
return 0;
- /* Use a dup-ed fd as closedir will close it. */
- dup_fd = dup(pmu->hwmon_dir_fd);
+ /*
+ * Use a dup-ed fd as closedir will close it. Use openat so that the
+ * directory contents are refreshed.
+ */
+ dup_fd = openat(pmu->hwmon_dir_fd, ".", O_DIRECTORY);
+
if (dup_fd == -1)
return -ENOMEM;
@@ -336,6 +340,9 @@ static int hwmon_pmu__read_events(struct hwmon_pmu *pmu)
close(fd);
}
}
+ if (hashmap__size(&pmu->events) == 0)
+ pr_debug2("hwmon_pmu: %s has no events\n", pmu->pmu.name);
+
hashmap__for_each_entry_safe((&pmu->events), cur, tmp, bkt) {
union hwmon_pmu_event_key key = {
.type_and_num = cur->key,
@@ -343,8 +350,8 @@ static int hwmon_pmu__read_events(struct hwmon_pmu *pmu)
struct hwmon_pmu_event_value *value = cur->pvalue;
if (!test_bit(HWMON_ITEM_INPUT, value->items)) {
- pr_debug("hwmon_pmu: removing event '%s%d' that has no input file\n",
- hwmon_type_strs[key.type], key.num);
+ pr_debug("hwmon_pmu: %s removing event '%s%d' that has no input file\n",
+ pmu->pmu.name, hwmon_type_strs[key.type], key.num);
hashmap__delete(&pmu->events, key.type_and_num, &key, &value);
zfree(&value->label);
zfree(&value->name);
--
2.47.0.338.g60cca15819-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v1 2/2] perf test hwmon_pmu: Fix event file location
2024-12-06 4:23 [PATCH v1 1/2] perf hwmon_pmu: Use openat rather than dup to refresh directory Ian Rogers
@ 2024-12-06 4:23 ` Ian Rogers
2024-12-09 21:16 ` Arnaldo Carvalho de Melo
2024-12-11 17:23 ` [PATCH v1 1/2] perf hwmon_pmu: Use openat rather than dup to refresh directory Namhyung Kim
1 sibling, 1 reply; 6+ messages in thread
From: Ian Rogers @ 2024-12-06 4:23 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Ian Rogers, Adrian Hunter, Kan Liang, linux-perf-users,
linux-kernel
The temp directory is made and a known fake hwmon PMU created within
it. Prior to this fix the events were being incorrectly written to the
temp directory rather than the fake PMU directory. This didn't impact
the test as the directory fd matched the wrong location, but it
doesn't mirror what a hwmon PMU would actually look like.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/hwmon_pmu.c | 29 ++++++++++++++++++-----------
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/tools/perf/tests/hwmon_pmu.c b/tools/perf/tests/hwmon_pmu.c
index f8bcee9660d5..d2b066a2b557 100644
--- a/tools/perf/tests/hwmon_pmu.c
+++ b/tools/perf/tests/hwmon_pmu.c
@@ -65,7 +65,7 @@ static struct perf_pmu *test_pmu_get(char *dir, size_t sz)
{ "temp2_label", "test hwmon event2\n", },
{ "temp2_input", "50000\n", },
};
- int dirfd, file;
+ int hwmon_dirfd = -1, test_dirfd = -1, file;
struct perf_pmu *hwm = NULL;
ssize_t len;
@@ -76,19 +76,24 @@ static struct perf_pmu *test_pmu_get(char *dir, size_t sz)
dir[0] = '\0';
return NULL;
}
- dirfd = open(dir, O_DIRECTORY);
- if (dirfd < 0) {
+ test_dirfd = open(dir, O_PATH|O_DIRECTORY);
+ if (test_dirfd < 0) {
pr_err("Failed to open test directory \"%s\"\n", dir);
goto err_out;
}
/* Create the test hwmon directory and give it a name. */
- if (mkdirat(dirfd, "hwmon1234", 0755) < 0) {
+ if (mkdirat(test_dirfd, "hwmon1234", 0755) < 0) {
pr_err("Failed to mkdir hwmon directory\n");
goto err_out;
}
- file = openat(dirfd, "hwmon1234/name", O_WRONLY | O_CREAT, 0600);
- if (!file) {
+ hwmon_dirfd = openat(test_dirfd, "hwmon1234", O_DIRECTORY);
+ if (hwmon_dirfd < 0) {
+ pr_err("Failed to open test hwmon directory \"%s/hwmon1234\"\n", dir);
+ goto err_out;
+ }
+ file = openat(hwmon_dirfd, "name", O_WRONLY | O_CREAT, 0600);
+ if (file < 0) {
pr_err("Failed to open for writing file \"name\"\n");
goto err_out;
}
@@ -104,8 +109,8 @@ static struct perf_pmu *test_pmu_get(char *dir, size_t sz)
for (size_t i = 0; i < ARRAY_SIZE(test_items); i++) {
const struct test_item *item = &test_items[i];
- file = openat(dirfd, item->name, O_WRONLY | O_CREAT, 0600);
- if (!file) {
+ file = openat(hwmon_dirfd, item->name, O_WRONLY | O_CREAT, 0600);
+ if (file < 0) {
pr_err("Failed to open for writing file \"%s\"\n", item->name);
goto err_out;
}
@@ -119,16 +124,18 @@ static struct perf_pmu *test_pmu_get(char *dir, size_t sz)
}
/* Make the PMU reading the files created above. */
- hwm = perf_pmus__add_test_hwmon_pmu(dirfd, "hwmon1234", test_hwmon_name);
+ hwm = perf_pmus__add_test_hwmon_pmu(hwmon_dirfd, "hwmon1234", test_hwmon_name);
if (!hwm)
pr_err("Test hwmon creation failed\n");
err_out:
if (!hwm) {
test_pmu_put(dir, hwm);
- if (dirfd >= 0)
- close(dirfd);
+ if (hwmon_dirfd >= 0)
+ close(hwmon_dirfd);
}
+ if (test_dirfd >= 0)
+ close(test_dirfd);
return hwm;
}
--
2.47.0.338.g60cca15819-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] perf test hwmon_pmu: Fix event file location
2024-12-06 4:23 ` [PATCH v1 2/2] perf test hwmon_pmu: Fix event file location Ian Rogers
@ 2024-12-09 21:16 ` Arnaldo Carvalho de Melo
2024-12-09 21:47 ` Namhyung Kim
0 siblings, 1 reply; 6+ messages in thread
From: Arnaldo Carvalho de Melo @ 2024-12-09 21:16 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Adrian Hunter, Kan Liang,
linux-perf-users, linux-kernel
On Thu, Dec 05, 2024 at 08:23:06PM -0800, Ian Rogers wrote:
> The temp directory is made and a known fake hwmon PMU created within
> it. Prior to this fix the events were being incorrectly written to the
> temp directory rather than the fake PMU directory. This didn't impact
> the test as the directory fd matched the wrong location, but it
> doesn't mirror what a hwmon PMU would actually look like.
With these two files the 'perf test 11' for hwmon is successfully
completed on my system where I previously reported failures.
Thanks, applied,
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/tests/hwmon_pmu.c | 29 ++++++++++++++++++-----------
> 1 file changed, 18 insertions(+), 11 deletions(-)
>
> diff --git a/tools/perf/tests/hwmon_pmu.c b/tools/perf/tests/hwmon_pmu.c
> index f8bcee9660d5..d2b066a2b557 100644
> --- a/tools/perf/tests/hwmon_pmu.c
> +++ b/tools/perf/tests/hwmon_pmu.c
> @@ -65,7 +65,7 @@ static struct perf_pmu *test_pmu_get(char *dir, size_t sz)
> { "temp2_label", "test hwmon event2\n", },
> { "temp2_input", "50000\n", },
> };
> - int dirfd, file;
> + int hwmon_dirfd = -1, test_dirfd = -1, file;
> struct perf_pmu *hwm = NULL;
> ssize_t len;
>
> @@ -76,19 +76,24 @@ static struct perf_pmu *test_pmu_get(char *dir, size_t sz)
> dir[0] = '\0';
> return NULL;
> }
> - dirfd = open(dir, O_DIRECTORY);
> - if (dirfd < 0) {
> + test_dirfd = open(dir, O_PATH|O_DIRECTORY);
> + if (test_dirfd < 0) {
> pr_err("Failed to open test directory \"%s\"\n", dir);
> goto err_out;
> }
>
> /* Create the test hwmon directory and give it a name. */
> - if (mkdirat(dirfd, "hwmon1234", 0755) < 0) {
> + if (mkdirat(test_dirfd, "hwmon1234", 0755) < 0) {
> pr_err("Failed to mkdir hwmon directory\n");
> goto err_out;
> }
> - file = openat(dirfd, "hwmon1234/name", O_WRONLY | O_CREAT, 0600);
> - if (!file) {
> + hwmon_dirfd = openat(test_dirfd, "hwmon1234", O_DIRECTORY);
> + if (hwmon_dirfd < 0) {
> + pr_err("Failed to open test hwmon directory \"%s/hwmon1234\"\n", dir);
> + goto err_out;
> + }
> + file = openat(hwmon_dirfd, "name", O_WRONLY | O_CREAT, 0600);
> + if (file < 0) {
> pr_err("Failed to open for writing file \"name\"\n");
> goto err_out;
> }
> @@ -104,8 +109,8 @@ static struct perf_pmu *test_pmu_get(char *dir, size_t sz)
> for (size_t i = 0; i < ARRAY_SIZE(test_items); i++) {
> const struct test_item *item = &test_items[i];
>
> - file = openat(dirfd, item->name, O_WRONLY | O_CREAT, 0600);
> - if (!file) {
> + file = openat(hwmon_dirfd, item->name, O_WRONLY | O_CREAT, 0600);
> + if (file < 0) {
> pr_err("Failed to open for writing file \"%s\"\n", item->name);
> goto err_out;
> }
> @@ -119,16 +124,18 @@ static struct perf_pmu *test_pmu_get(char *dir, size_t sz)
> }
>
> /* Make the PMU reading the files created above. */
> - hwm = perf_pmus__add_test_hwmon_pmu(dirfd, "hwmon1234", test_hwmon_name);
> + hwm = perf_pmus__add_test_hwmon_pmu(hwmon_dirfd, "hwmon1234", test_hwmon_name);
> if (!hwm)
> pr_err("Test hwmon creation failed\n");
>
> err_out:
> if (!hwm) {
> test_pmu_put(dir, hwm);
> - if (dirfd >= 0)
> - close(dirfd);
> + if (hwmon_dirfd >= 0)
> + close(hwmon_dirfd);
> }
> + if (test_dirfd >= 0)
> + close(test_dirfd);
> return hwm;
> }
>
> --
> 2.47.0.338.g60cca15819-goog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] perf test hwmon_pmu: Fix event file location
2024-12-09 21:16 ` Arnaldo Carvalho de Melo
@ 2024-12-09 21:47 ` Namhyung Kim
2024-12-10 13:57 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 6+ messages in thread
From: Namhyung Kim @ 2024-12-09 21:47 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Ian Rogers, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Adrian Hunter, Kan Liang,
linux-perf-users, linux-kernel
On Mon, Dec 9, 2024 at 1:16 PM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> On Thu, Dec 05, 2024 at 08:23:06PM -0800, Ian Rogers wrote:
> > The temp directory is made and a known fake hwmon PMU created within
> > it. Prior to this fix the events were being incorrectly written to the
> > temp directory rather than the fake PMU directory. This didn't impact
> > the test as the directory fd matched the wrong location, but it
> > doesn't mirror what a hwmon PMU would actually look like.
>
> With these two files the 'perf test 11' for hwmon is successfully
> completed on my system where I previously reported failures.
>
> Thanks, applied,
I think it can go to perf-tools.
Thanks,
Namhyung
>
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> > tools/perf/tests/hwmon_pmu.c | 29 ++++++++++++++++++-----------
> > 1 file changed, 18 insertions(+), 11 deletions(-)
> >
> > diff --git a/tools/perf/tests/hwmon_pmu.c b/tools/perf/tests/hwmon_pmu.c
> > index f8bcee9660d5..d2b066a2b557 100644
> > --- a/tools/perf/tests/hwmon_pmu.c
> > +++ b/tools/perf/tests/hwmon_pmu.c
> > @@ -65,7 +65,7 @@ static struct perf_pmu *test_pmu_get(char *dir, size_t sz)
> > { "temp2_label", "test hwmon event2\n", },
> > { "temp2_input", "50000\n", },
> > };
> > - int dirfd, file;
> > + int hwmon_dirfd = -1, test_dirfd = -1, file;
> > struct perf_pmu *hwm = NULL;
> > ssize_t len;
> >
> > @@ -76,19 +76,24 @@ static struct perf_pmu *test_pmu_get(char *dir, size_t sz)
> > dir[0] = '\0';
> > return NULL;
> > }
> > - dirfd = open(dir, O_DIRECTORY);
> > - if (dirfd < 0) {
> > + test_dirfd = open(dir, O_PATH|O_DIRECTORY);
> > + if (test_dirfd < 0) {
> > pr_err("Failed to open test directory \"%s\"\n", dir);
> > goto err_out;
> > }
> >
> > /* Create the test hwmon directory and give it a name. */
> > - if (mkdirat(dirfd, "hwmon1234", 0755) < 0) {
> > + if (mkdirat(test_dirfd, "hwmon1234", 0755) < 0) {
> > pr_err("Failed to mkdir hwmon directory\n");
> > goto err_out;
> > }
> > - file = openat(dirfd, "hwmon1234/name", O_WRONLY | O_CREAT, 0600);
> > - if (!file) {
> > + hwmon_dirfd = openat(test_dirfd, "hwmon1234", O_DIRECTORY);
> > + if (hwmon_dirfd < 0) {
> > + pr_err("Failed to open test hwmon directory \"%s/hwmon1234\"\n", dir);
> > + goto err_out;
> > + }
> > + file = openat(hwmon_dirfd, "name", O_WRONLY | O_CREAT, 0600);
> > + if (file < 0) {
> > pr_err("Failed to open for writing file \"name\"\n");
> > goto err_out;
> > }
> > @@ -104,8 +109,8 @@ static struct perf_pmu *test_pmu_get(char *dir, size_t sz)
> > for (size_t i = 0; i < ARRAY_SIZE(test_items); i++) {
> > const struct test_item *item = &test_items[i];
> >
> > - file = openat(dirfd, item->name, O_WRONLY | O_CREAT, 0600);
> > - if (!file) {
> > + file = openat(hwmon_dirfd, item->name, O_WRONLY | O_CREAT, 0600);
> > + if (file < 0) {
> > pr_err("Failed to open for writing file \"%s\"\n", item->name);
> > goto err_out;
> > }
> > @@ -119,16 +124,18 @@ static struct perf_pmu *test_pmu_get(char *dir, size_t sz)
> > }
> >
> > /* Make the PMU reading the files created above. */
> > - hwm = perf_pmus__add_test_hwmon_pmu(dirfd, "hwmon1234", test_hwmon_name);
> > + hwm = perf_pmus__add_test_hwmon_pmu(hwmon_dirfd, "hwmon1234", test_hwmon_name);
> > if (!hwm)
> > pr_err("Test hwmon creation failed\n");
> >
> > err_out:
> > if (!hwm) {
> > test_pmu_put(dir, hwm);
> > - if (dirfd >= 0)
> > - close(dirfd);
> > + if (hwmon_dirfd >= 0)
> > + close(hwmon_dirfd);
> > }
> > + if (test_dirfd >= 0)
> > + close(test_dirfd);
> > return hwm;
> > }
> >
> > --
> > 2.47.0.338.g60cca15819-goog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] perf test hwmon_pmu: Fix event file location
2024-12-09 21:47 ` Namhyung Kim
@ 2024-12-10 13:57 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 6+ messages in thread
From: Arnaldo Carvalho de Melo @ 2024-12-10 13:57 UTC (permalink / raw)
To: Namhyung Kim
Cc: Ian Rogers, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Adrian Hunter, Kan Liang,
linux-perf-users, linux-kernel
On Mon, Dec 09, 2024 at 01:47:01PM -0800, Namhyung Kim wrote:
> On Mon, Dec 9, 2024 at 1:16 PM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> >
> > On Thu, Dec 05, 2024 at 08:23:06PM -0800, Ian Rogers wrote:
> > > The temp directory is made and a known fake hwmon PMU created within
> > > it. Prior to this fix the events were being incorrectly written to the
> > > temp directory rather than the fake PMU directory. This didn't impact
> > > the test as the directory fd matched the wrong location, but it
> > > doesn't mirror what a hwmon PMU would actually look like.
> >
> > With these two files the 'perf test 11' for hwmon is successfully
> > completed on my system where I previously reported failures.
> >
> > Thanks, applied,
>
> I think it can go to perf-tools.
Please do so and also add:
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
- Arnaldo
> Thanks,
> Namhyung
>
> >
> > > Signed-off-by: Ian Rogers <irogers@google.com>
> > > ---
> > > tools/perf/tests/hwmon_pmu.c | 29 ++++++++++++++++++-----------
> > > 1 file changed, 18 insertions(+), 11 deletions(-)
> > >
> > > diff --git a/tools/perf/tests/hwmon_pmu.c b/tools/perf/tests/hwmon_pmu.c
> > > index f8bcee9660d5..d2b066a2b557 100644
> > > --- a/tools/perf/tests/hwmon_pmu.c
> > > +++ b/tools/perf/tests/hwmon_pmu.c
> > > @@ -65,7 +65,7 @@ static struct perf_pmu *test_pmu_get(char *dir, size_t sz)
> > > { "temp2_label", "test hwmon event2\n", },
> > > { "temp2_input", "50000\n", },
> > > };
> > > - int dirfd, file;
> > > + int hwmon_dirfd = -1, test_dirfd = -1, file;
> > > struct perf_pmu *hwm = NULL;
> > > ssize_t len;
> > >
> > > @@ -76,19 +76,24 @@ static struct perf_pmu *test_pmu_get(char *dir, size_t sz)
> > > dir[0] = '\0';
> > > return NULL;
> > > }
> > > - dirfd = open(dir, O_DIRECTORY);
> > > - if (dirfd < 0) {
> > > + test_dirfd = open(dir, O_PATH|O_DIRECTORY);
> > > + if (test_dirfd < 0) {
> > > pr_err("Failed to open test directory \"%s\"\n", dir);
> > > goto err_out;
> > > }
> > >
> > > /* Create the test hwmon directory and give it a name. */
> > > - if (mkdirat(dirfd, "hwmon1234", 0755) < 0) {
> > > + if (mkdirat(test_dirfd, "hwmon1234", 0755) < 0) {
> > > pr_err("Failed to mkdir hwmon directory\n");
> > > goto err_out;
> > > }
> > > - file = openat(dirfd, "hwmon1234/name", O_WRONLY | O_CREAT, 0600);
> > > - if (!file) {
> > > + hwmon_dirfd = openat(test_dirfd, "hwmon1234", O_DIRECTORY);
> > > + if (hwmon_dirfd < 0) {
> > > + pr_err("Failed to open test hwmon directory \"%s/hwmon1234\"\n", dir);
> > > + goto err_out;
> > > + }
> > > + file = openat(hwmon_dirfd, "name", O_WRONLY | O_CREAT, 0600);
> > > + if (file < 0) {
> > > pr_err("Failed to open for writing file \"name\"\n");
> > > goto err_out;
> > > }
> > > @@ -104,8 +109,8 @@ static struct perf_pmu *test_pmu_get(char *dir, size_t sz)
> > > for (size_t i = 0; i < ARRAY_SIZE(test_items); i++) {
> > > const struct test_item *item = &test_items[i];
> > >
> > > - file = openat(dirfd, item->name, O_WRONLY | O_CREAT, 0600);
> > > - if (!file) {
> > > + file = openat(hwmon_dirfd, item->name, O_WRONLY | O_CREAT, 0600);
> > > + if (file < 0) {
> > > pr_err("Failed to open for writing file \"%s\"\n", item->name);
> > > goto err_out;
> > > }
> > > @@ -119,16 +124,18 @@ static struct perf_pmu *test_pmu_get(char *dir, size_t sz)
> > > }
> > >
> > > /* Make the PMU reading the files created above. */
> > > - hwm = perf_pmus__add_test_hwmon_pmu(dirfd, "hwmon1234", test_hwmon_name);
> > > + hwm = perf_pmus__add_test_hwmon_pmu(hwmon_dirfd, "hwmon1234", test_hwmon_name);
> > > if (!hwm)
> > > pr_err("Test hwmon creation failed\n");
> > >
> > > err_out:
> > > if (!hwm) {
> > > test_pmu_put(dir, hwm);
> > > - if (dirfd >= 0)
> > > - close(dirfd);
> > > + if (hwmon_dirfd >= 0)
> > > + close(hwmon_dirfd);
> > > }
> > > + if (test_dirfd >= 0)
> > > + close(test_dirfd);
> > > return hwm;
> > > }
> > >
> > > --
> > > 2.47.0.338.g60cca15819-goog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/2] perf hwmon_pmu: Use openat rather than dup to refresh directory
2024-12-06 4:23 [PATCH v1 1/2] perf hwmon_pmu: Use openat rather than dup to refresh directory Ian Rogers
2024-12-06 4:23 ` [PATCH v1 2/2] perf test hwmon_pmu: Fix event file location Ian Rogers
@ 2024-12-11 17:23 ` Namhyung Kim
1 sibling, 0 replies; 6+ messages in thread
From: Namhyung Kim @ 2024-12-11 17:23 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
Kan Liang, linux-perf-users, linux-kernel, Ian Rogers
On Thu, 05 Dec 2024 20:23:05 -0800, Ian Rogers wrote:
> The hwmon PMU test will make a temp directory, open the directory with
> O_DIRECTORY then fill it with contents. As the open is before the
> filling the contents the later fdopendir may reflect the initial empty
> state, meaning no events are seen. Change to re-open the directory,
> rather than dup the fd, so the latest contents are seen.
>
> Minor tweaks/additions to debug messages.
>
> [...]
Applied to perf-tools, thanks!
Best regards,
Namhyung
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-12-11 17:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-06 4:23 [PATCH v1 1/2] perf hwmon_pmu: Use openat rather than dup to refresh directory Ian Rogers
2024-12-06 4:23 ` [PATCH v1 2/2] perf test hwmon_pmu: Fix event file location Ian Rogers
2024-12-09 21:16 ` Arnaldo Carvalho de Melo
2024-12-09 21:47 ` Namhyung Kim
2024-12-10 13:57 ` Arnaldo Carvalho de Melo
2024-12-11 17:23 ` [PATCH v1 1/2] perf hwmon_pmu: Use openat rather than dup to refresh directory Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox