* [PATCH] ASoC: cs42l43: don't include '<linux/find.h>' directly
@ 2024-12-17 7:05 Wolfram Sang
2024-12-17 10:25 ` Charles Keepax
2024-12-17 15:48 ` Mark Brown
0 siblings, 2 replies; 5+ messages in thread
From: Wolfram Sang @ 2024-12-17 7:05 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, David Rhodes, Richard Fitzgerald, Liam Girdwood,
Mark Brown, Jaroslav Kysela, Takashi Iwai, linux-sound, patches
The header clearly states that it does not want to be included directly,
only via '<linux/bitmap.h>'. Replace the include accordingly.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
sound/soc/codecs/cs42l43.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/cs42l43.c b/sound/soc/codecs/cs42l43.c
index 4236f78beec0..bee032c3ebbe 100644
--- a/sound/soc/codecs/cs42l43.c
+++ b/sound/soc/codecs/cs42l43.c
@@ -12,7 +12,7 @@
#include <linux/device.h>
#include <linux/err.h>
#include <linux/errno.h>
-#include <linux/find.h>
+#include <linux/bitmap.h>
#include <linux/gcd.h>
#include <linux/irq.h>
#include <linux/irqdomain.h>
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: cs42l43: don't include '<linux/find.h>' directly
2024-12-17 7:05 [PATCH] ASoC: cs42l43: don't include '<linux/find.h>' directly Wolfram Sang
@ 2024-12-17 10:25 ` Charles Keepax
2024-12-17 15:48 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Charles Keepax @ 2024-12-17 10:25 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, David Rhodes, Richard Fitzgerald, Liam Girdwood,
Mark Brown, Jaroslav Kysela, Takashi Iwai, linux-sound, patches
On Tue, Dec 17, 2024 at 08:05:45AM +0100, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via '<linux/bitmap.h>'. Replace the include accordingly.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: cs42l43: don't include '<linux/find.h>' directly
2024-12-17 7:05 [PATCH] ASoC: cs42l43: don't include '<linux/find.h>' directly Wolfram Sang
2024-12-17 10:25 ` Charles Keepax
@ 2024-12-17 15:48 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2024-12-17 15:48 UTC (permalink / raw)
To: linux-kernel, Wolfram Sang
Cc: David Rhodes, Richard Fitzgerald, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, linux-sound, patches
On Tue, 17 Dec 2024 08:05:45 +0100, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via '<linux/bitmap.h>'. Replace the include accordingly.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: cs42l43: don't include '<linux/find.h>' directly
commit: db8b9b12892f0528c3a78715243c22398ab3cb5d
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ASoC: cs42l43: don't include '<linux/find.h>' directly
@ 2024-12-23 3:44 Ethan Carter Edwards
2024-12-23 3:49 ` Ethan Carter Edwards
0 siblings, 1 reply; 5+ messages in thread
From: Ethan Carter Edwards @ 2024-12-23 3:44 UTC (permalink / raw)
To: david.rhodes@cirrus.com
Cc: linux-kernel@vger.kernel.org, rf@opensource.cirrus.com,
patches@opensource.cirrus.com, linux-sound@vger.kernel.org
The header in <linux/find.h> explicitly states that it should not be
included directly and instead use bitmap.h.
Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
---
sound/soc/codecs/cs42l43.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/cs42l43.c b/sound/soc/codecs/cs42l43.c
index 4236f78beec0..bee032c3ebbe 100644
--- a/sound/soc/codecs/cs42l43.c
+++ b/sound/soc/codecs/cs42l43.c
@@ -12,7 +12,7 @@
#include <linux/device.h>
#include <linux/err.h>
#include <linux/errno.h>
-#include <linux/find.h>
+#include <linux/bitmap.h>
#include <linux/gcd.h>
#include <linux/irq.h>
#include <linux/irqdomain.h>
--
2.47.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: cs42l43: don't include '<linux/find.h>' directly
2024-12-23 3:44 Ethan Carter Edwards
@ 2024-12-23 3:49 ` Ethan Carter Edwards
0 siblings, 0 replies; 5+ messages in thread
From: Ethan Carter Edwards @ 2024-12-23 3:49 UTC (permalink / raw)
To: david.rhodes@cirrus.com
Cc: linux-kernel@vger.kernel.org, rf@opensource.cirrus.com,
patches@opensource.cirrus.com, linux-sound@vger.kernel.org
Just realized someone else got this via lore.kernel.org. My tree didn't include those changes. Sorry! Let me know how I can avoid doing that in the future, new dev. here.
Thanks,
Ethan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-12-23 3:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-17 7:05 [PATCH] ASoC: cs42l43: don't include '<linux/find.h>' directly Wolfram Sang
2024-12-17 10:25 ` Charles Keepax
2024-12-17 15:48 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2024-12-23 3:44 Ethan Carter Edwards
2024-12-23 3:49 ` Ethan Carter Edwards
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox