* drivers/android/binder.c:1819: warning: Function parameter or struct member 'file' not described in 'binder_task_work_cb'
@ 2025-01-03 7:39 kernel test robot
2025-01-03 17:54 ` Uladzislau Rezki
2025-01-06 19:26 ` [PATCH] binder: fix kernel-doc warning of 'file' member Carlos Llamas
0 siblings, 2 replies; 4+ messages in thread
From: kernel test robot @ 2025-01-03 7:39 UTC (permalink / raw)
To: Uladzislau Rezki
Cc: oe-kbuild-all, linux-kernel, Paul E. McKenney,
Uladzislau Rezki (Sony)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0bc21e701a6ffacfdde7f04f87d664d82e8a13bf
commit: 28b3ae426598e722cf5d5ab9cc7038791b955a56 rcu: Introduce CONFIG_RCU_EXP_CPU_STALL_TIMEOUT
date: 2 years, 8 months ago
config: csky-randconfig-r022-20230522 (https://download.01.org/0day-ci/archive/20250103/202501031535.erbln3A2-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250103/202501031535.erbln3A2-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501031535.erbln3A2-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/android/binder.c:233: warning: Function parameter or struct member '_proc' not described in 'binder_proc_unlock'
drivers/android/binder.c:233: warning: Excess function parameter 'proc' description in 'binder_proc_unlock'
drivers/android/binder.c:335: warning: expecting prototype for binder_node_unlock(). Prototype was for binder_node_inner_unlock() instead
drivers/android/binder.c:1155: warning: expecting prototype for binder_dec_ref(). Prototype was for binder_dec_ref_olocked() instead
>> drivers/android/binder.c:1819: warning: Function parameter or struct member 'file' not described in 'binder_task_work_cb'
>> drivers/android/binder.c:1819: warning: Excess struct member 'fd' description in 'binder_task_work_cb'
>> drivers/android/binder.c:2254: warning: Function parameter or struct member 'offset' not described in 'binder_ptr_fixup'
>> drivers/android/binder.c:2254: warning: Function parameter or struct member 'skip_size' not described in 'binder_ptr_fixup'
>> drivers/android/binder.c:2254: warning: Function parameter or struct member 'fixup_data' not described in 'binder_ptr_fixup'
>> drivers/android/binder.c:2254: warning: Function parameter or struct member 'node' not described in 'binder_ptr_fixup'
>> drivers/android/binder.c:2274: warning: Function parameter or struct member 'offset' not described in 'binder_sg_copy'
>> drivers/android/binder.c:2274: warning: Function parameter or struct member 'sender_uaddr' not described in 'binder_sg_copy'
>> drivers/android/binder.c:2274: warning: Function parameter or struct member 'length' not described in 'binder_sg_copy'
>> drivers/android/binder.c:2274: warning: Function parameter or struct member 'node' not described in 'binder_sg_copy'
drivers/android/binder.c:2683: warning: Function parameter or struct member 'procp' not described in 'binder_get_node_refs_for_txn'
drivers/android/binder.c:2683: warning: Excess function parameter 'proc' description in 'binder_get_node_refs_for_txn'
>> drivers/android/binder.c:3510: warning: Function parameter or struct member 'thread' not described in 'binder_free_buf'
vim +1819 drivers/android/binder.c
7980240b6d63e0 Martijn Coenen 2017-02-03 1806
80cd795630d652 Todd Kjos 2018-12-14 1807 /**
80cd795630d652 Todd Kjos 2018-12-14 1808 * struct binder_task_work_cb - for deferred close
80cd795630d652 Todd Kjos 2018-12-14 1809 *
80cd795630d652 Todd Kjos 2018-12-14 1810 * @twork: callback_head for task work
80cd795630d652 Todd Kjos 2018-12-14 1811 * @fd: fd to close
80cd795630d652 Todd Kjos 2018-12-14 1812 *
80cd795630d652 Todd Kjos 2018-12-14 1813 * Structure to pass task work to be handled after
80cd795630d652 Todd Kjos 2018-12-14 1814 * returning from binder_ioctl() via task_work_add().
80cd795630d652 Todd Kjos 2018-12-14 1815 */
80cd795630d652 Todd Kjos 2018-12-14 1816 struct binder_task_work_cb {
80cd795630d652 Todd Kjos 2018-12-14 1817 struct callback_head twork;
80cd795630d652 Todd Kjos 2018-12-14 1818 struct file *file;
80cd795630d652 Todd Kjos 2018-12-14 @1819 };
80cd795630d652 Todd Kjos 2018-12-14 1820
:::::: The code at line 1819 was first introduced by commit
:::::: 80cd795630d6526ba729a089a435bf74a57af927 binder: fix use-after-free due to ksys_close() during fdget()
:::::: TO: Todd Kjos <tkjos@android.com>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/android/binder.c:1819: warning: Function parameter or struct member 'file' not described in 'binder_task_work_cb'
2025-01-03 7:39 drivers/android/binder.c:1819: warning: Function parameter or struct member 'file' not described in 'binder_task_work_cb' kernel test robot
@ 2025-01-03 17:54 ` Uladzislau Rezki
2025-01-06 19:26 ` [PATCH] binder: fix kernel-doc warning of 'file' member Carlos Llamas
1 sibling, 0 replies; 4+ messages in thread
From: Uladzislau Rezki @ 2025-01-03 17:54 UTC (permalink / raw)
To: Todd Kjos
Cc: Uladzislau Rezki, oe-kbuild-all, linux-kernel, Paul E. McKenney,
Uladzislau Rezki (Sony)
On Fri, Jan 03, 2025 at 03:39:37PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 0bc21e701a6ffacfdde7f04f87d664d82e8a13bf
> commit: 28b3ae426598e722cf5d5ab9cc7038791b955a56 rcu: Introduce CONFIG_RCU_EXP_CPU_STALL_TIMEOUT
> date: 2 years, 8 months ago
> config: csky-randconfig-r022-20230522 (https://download.01.org/0day-ci/archive/20250103/202501031535.erbln3A2-lkp@intel.com/config)
> compiler: csky-linux-gcc (GCC) 12.4.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250103/202501031535.erbln3A2-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202501031535.erbln3A2-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> drivers/android/binder.c:233: warning: Function parameter or struct member '_proc' not described in 'binder_proc_unlock'
> drivers/android/binder.c:233: warning: Excess function parameter 'proc' description in 'binder_proc_unlock'
> drivers/android/binder.c:335: warning: expecting prototype for binder_node_unlock(). Prototype was for binder_node_inner_unlock() instead
> drivers/android/binder.c:1155: warning: expecting prototype for binder_dec_ref(). Prototype was for binder_dec_ref_olocked() instead
> >> drivers/android/binder.c:1819: warning: Function parameter or struct member 'file' not described in 'binder_task_work_cb'
> >> drivers/android/binder.c:1819: warning: Excess struct member 'fd' description in 'binder_task_work_cb'
> >> drivers/android/binder.c:2254: warning: Function parameter or struct member 'offset' not described in 'binder_ptr_fixup'
> >> drivers/android/binder.c:2254: warning: Function parameter or struct member 'skip_size' not described in 'binder_ptr_fixup'
> >> drivers/android/binder.c:2254: warning: Function parameter or struct member 'fixup_data' not described in 'binder_ptr_fixup'
> >> drivers/android/binder.c:2254: warning: Function parameter or struct member 'node' not described in 'binder_ptr_fixup'
> >> drivers/android/binder.c:2274: warning: Function parameter or struct member 'offset' not described in 'binder_sg_copy'
> >> drivers/android/binder.c:2274: warning: Function parameter or struct member 'sender_uaddr' not described in 'binder_sg_copy'
> >> drivers/android/binder.c:2274: warning: Function parameter or struct member 'length' not described in 'binder_sg_copy'
> >> drivers/android/binder.c:2274: warning: Function parameter or struct member 'node' not described in 'binder_sg_copy'
> drivers/android/binder.c:2683: warning: Function parameter or struct member 'procp' not described in 'binder_get_node_refs_for_txn'
> drivers/android/binder.c:2683: warning: Excess function parameter 'proc' description in 'binder_get_node_refs_for_txn'
> >> drivers/android/binder.c:3510: warning: Function parameter or struct member 'thread' not described in 'binder_free_buf'
>
>
> vim +1819 drivers/android/binder.c
>
> 7980240b6d63e0 Martijn Coenen 2017-02-03 1806
> 80cd795630d652 Todd Kjos 2018-12-14 1807 /**
> 80cd795630d652 Todd Kjos 2018-12-14 1808 * struct binder_task_work_cb - for deferred close
> 80cd795630d652 Todd Kjos 2018-12-14 1809 *
> 80cd795630d652 Todd Kjos 2018-12-14 1810 * @twork: callback_head for task work
> 80cd795630d652 Todd Kjos 2018-12-14 1811 * @fd: fd to close
> 80cd795630d652 Todd Kjos 2018-12-14 1812 *
> 80cd795630d652 Todd Kjos 2018-12-14 1813 * Structure to pass task work to be handled after
> 80cd795630d652 Todd Kjos 2018-12-14 1814 * returning from binder_ioctl() via task_work_add().
> 80cd795630d652 Todd Kjos 2018-12-14 1815 */
> 80cd795630d652 Todd Kjos 2018-12-14 1816 struct binder_task_work_cb {
> 80cd795630d652 Todd Kjos 2018-12-14 1817 struct callback_head twork;
> 80cd795630d652 Todd Kjos 2018-12-14 1818 struct file *file;
> 80cd795630d652 Todd Kjos 2018-12-14 @1819 };
> 80cd795630d652 Todd Kjos 2018-12-14 1820
>
> :::::: The code at line 1819 was first introduced by commit
> :::::: 80cd795630d6526ba729a089a435bf74a57af927 binder: fix use-after-free due to ksys_close() during fdget()
>
Above warnings have nothing to do with the:
commit: 28b3ae426598e722cf5d5ab9cc7038791b955a56 rcu: Introduce CONFIG_RCU_EXP_CPU_STALL_TIMEOUT
Add "Todd Kjos <tkjos@android.com>", owner of the patch, to sort those warnings out.
--
Uladzislau Rezki
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] binder: fix kernel-doc warning of 'file' member
2025-01-03 7:39 drivers/android/binder.c:1819: warning: Function parameter or struct member 'file' not described in 'binder_task_work_cb' kernel test robot
2025-01-03 17:54 ` Uladzislau Rezki
@ 2025-01-06 19:26 ` Carlos Llamas
2025-01-06 20:01 ` Todd Kjos
1 sibling, 1 reply; 4+ messages in thread
From: Carlos Llamas @ 2025-01-06 19:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner, Carlos Llamas,
Suren Baghdasaryan
Cc: linux-kernel, kernel-team, oe-kbuild-all, paulmck,
uladzislau.rezki, urezki, Todd Kjos, kernel test robot
The 'struct file' member in 'binder_task_work_cb' definition was renamed
to 'file' between patch versions but its kernel-doc reference kept the
old name 'fd'. Update the naming to fix the W=1 build warning.
Cc: Todd Kjos <tkjos@google.com>
Fixes: 80cd795630d6 ("binder: fix use-after-free due to ksys_close() during fdget()")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501031535.erbln3A2-lkp@intel.com/
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---
drivers/android/binder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index ef353ca13c35..f790356750e9 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -1971,7 +1971,7 @@ static bool binder_validate_fixup(struct binder_proc *proc,
* struct binder_task_work_cb - for deferred close
*
* @twork: callback_head for task work
- * @fd: fd to close
+ * @file: file to close
*
* Structure to pass task work to be handled after
* returning from binder_ioctl() via task_work_add().
--
2.47.1.613.gc27f4b7a9f-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] binder: fix kernel-doc warning of 'file' member
2025-01-06 19:26 ` [PATCH] binder: fix kernel-doc warning of 'file' member Carlos Llamas
@ 2025-01-06 20:01 ` Todd Kjos
0 siblings, 0 replies; 4+ messages in thread
From: Todd Kjos @ 2025-01-06 20:01 UTC (permalink / raw)
To: Carlos Llamas
Cc: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner,
Suren Baghdasaryan, linux-kernel, kernel-team, oe-kbuild-all,
paulmck, uladzislau.rezki, urezki, kernel test robot
On Mon, Jan 6, 2025 at 11:26 AM Carlos Llamas <cmllamas@google.com> wrote:
>
> The 'struct file' member in 'binder_task_work_cb' definition was renamed
> to 'file' between patch versions but its kernel-doc reference kept the
> old name 'fd'. Update the naming to fix the W=1 build warning.
>
> Cc: Todd Kjos <tkjos@google.com>
> Fixes: 80cd795630d6 ("binder: fix use-after-free due to ksys_close() during fdget()")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501031535.erbln3A2-lkp@intel.com/
> Signed-off-by: Carlos Llamas <cmllamas@google.com>
Acked-by: Todd Kjos <tkjos@google.com>
> ---
> drivers/android/binder.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index ef353ca13c35..f790356750e9 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -1971,7 +1971,7 @@ static bool binder_validate_fixup(struct binder_proc *proc,
> * struct binder_task_work_cb - for deferred close
> *
> * @twork: callback_head for task work
> - * @fd: fd to close
> + * @file: file to close
> *
> * Structure to pass task work to be handled after
> * returning from binder_ioctl() via task_work_add().
> --
> 2.47.1.613.gc27f4b7a9f-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-06 20:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-03 7:39 drivers/android/binder.c:1819: warning: Function parameter or struct member 'file' not described in 'binder_task_work_cb' kernel test robot
2025-01-03 17:54 ` Uladzislau Rezki
2025-01-06 19:26 ` [PATCH] binder: fix kernel-doc warning of 'file' member Carlos Llamas
2025-01-06 20:01 ` Todd Kjos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox