rust/kernel/lib.rs:17:12 : warning: the feature `new_uninit` has been stable since 1.82.0 and no longer requires an attribute to enable

rust/kernel/lib.rs:17:12 : warning: the feature `new_uninit` has been stable since 1.82.0 and no longer requires an attribute to enable

[Naresh Kamboju]

The following kselftest rust builds failed on sashal/linus-next.git
due to following build warnings / errors.

Good: 829d8581c398a96deea1d6bc78578950347dcbec
Bad:   b2d472701a703596889c3fd067fd8929aeffc4be

Build error:
--------------
warning: the feature `new_uninit` has been stable since 1.82.0 and no
longer requires an attribute to enable
  --> /rust/kernel/lib.rs:17:12
   |
17 | #![feature(new_uninit)]
   |            ^^^^^^^^^^
   |
   = note: `#[warn(stable_features)]` on by default

error[E0658]: use of unstable library feature 'box_uninit_write'
  --> /rust/kernel/alloc/box_ext.rs:41:12
   |
41 |         Ok(Box::write(b, x))
   |            ^^^^^^^^^^
   |
   = note: see issue #129397
<https://github.com/rust-lang/rust/issues/129397> for more information
   = help: add `#![feature(box_uninit_write)]` to the crate attributes to enable
   = note: this compiler was built on 2024-11-26; consider upgrading
it if it is out of date

error: aborting due to 1 previous error; 1 warning emitted

For more information about this error, try `rustc --explain E0658`.
make[3]: *** [/rust/Makefile:425: rust/kernel.o] Error 1

Links:
-------
 - https://qa-reports.linaro.org/lkft/sashal-linus-next/build/v6.11-rc4-6237-gb2d472701a70/testrun/26563483/suite/build/test/rustgcc-lkftconfig-kselftest/log
 - https://qa-reports.linaro.org/lkft/sashal-linus-next/build/v6.11-rc4-6237-gb2d472701a70/testrun/26563483/suite/build/test/rustgcc-lkftconfig-kselftest/history/
 - https://qa-reports.linaro.org/lkft/sashal-linus-next/build/v6.11-rc4-6237-gb2d472701a70/testrun/26563483/suite/build/test/rustgcc-lkftconfig-kselftest/details/

metadata:
----
  git repo: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linus-next.git
  kernel config:
https://storage.tuxsuite.com/public/linaro/lkft/builds/2rByIOiC9ssqI7NjEPY7IcRs8SN/config
  build url: https://storage.tuxsuite.com/public/linaro/lkft/builds/2rByIOiC9ssqI7NjEPY7IcRs8SN/
  toolchain: rustgcc
  compiler: 'name': 'gcc', 'version': '14', 'version_full': 'gcc
(Debian 14.2.0-8) 14.2.0'
  config: rustgcc-lkftconfig-kselftest
  arch: arm64


 --
Linaro LKFT
https://lkft.linaro.org

Re: rust/kernel/lib.rs:17:12 : warning: the feature `new_uninit` has been stable since 1.82.0 and no longer requires an attribute to enable

[Miguel Ojeda]

On Sun, Jan 5, 2025 at 9:42 AM Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> The following kselftest rust builds failed on sashal/linus-next.git
> due to following build warnings / errors.
>
> Good: 829d8581c398a96deea1d6bc78578950347dcbec
> Bad:   b2d472701a703596889c3fd067fd8929aeffc4be

These seem unrelated, old but rebased/recommitted recently (without SoB).

> warning: the feature `new_uninit` has been stable since 1.82.0 and no
> longer requires an attribute to enable
>   --> /rust/kernel/lib.rs:17:12
>    |
> 17 | #![feature(new_uninit)]
>    |            ^^^^^^^^^^
>    |
>    = note: `#[warn(stable_features)]` on by default

This should not happen since commit 8e95e53ca379 ("rust: allow
`stable_features` lint"), which is in v6.11-rc7.

> error[E0658]: use of unstable library feature 'box_uninit_write'
>   --> /rust/kernel/alloc/box_ext.rs:41:12
>    |
> 41 |         Ok(Box::write(b, x))
>    |            ^^^^^^^^^^
>    |
>    = note: see issue #129397
> <https://github.com/rust-lang/rust/issues/129397> for more information
>    = help: add `#![feature(box_uninit_write)]` to the crate attributes to enable
>    = note: this compiler was built on 2024-11-26; consider upgrading
> it if it is out of date

This should not happen since commit 0903b9e2a46c ("rust: alloc: eschew
`Box<MaybeUninit<T>>::write`"), which is also in v6.11-rc7. (The file
is gone nowadays too, since v6.13-rc1).

>  toolchain: rustgcc
>   compiler: 'name': 'gcc', 'version': '14', 'version_full': 'gcc
> (Debian 14.2.0-8) 14.2.0'

By the way, it would be nice to mention here the Rust compiler too, if used.

Thanks for the report! I think there is nothing to be done here given
the details above.

Cheers,
Miguel

Re: rust/kernel/lib.rs:17:12 : warning: the feature `new_uninit` has been stable since 1.82.0 and no longer requires an attribute to enable

[Miguel Ojeda]

On Sun, Jan 5, 2025 at 2:33 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> Thanks for the report! I think there is nothing to be done here given
> the details above.

To clarify: v6.11.y is newer (and EOL), v6.12.y LTS is newer, and
older LTSs had the Rust toolchain pinned.

If there is something I am missing, please let me know.

Thanks!

Cheers,
Miguel

Re: rust/kernel/lib.rs:17:12 : warning: the feature `new_uninit` has been stable since 1.82.0 and no longer requires an attribute to enable

[Sasha Levin]

I'm sorry, this is my bad: I haven't realized anyone else will be
looking at these results...

Naresh, I'm cheating and using this tree to bisect the issue you've
originally reported in
https://lore.kernel.org/all/CA+G9fYvcBvbabg+m7brKfpGCGZUcK+KHHTFX7hFvW6GmN2XF0g@mail.gmail.com/
.

It seems we can't get traction to get it fixes, so I'm trying to make
forward progress.

Please ignore linus-next for the next day or two :)

-- 
Thanks,
Sasha

Re: rust/kernel/lib.rs:17:12 : warning: the feature `new_uninit` has been stable since 1.82.0 and no longer requires an attribute to enable

[Naresh Kamboju]

On Sun, 5 Jan 2025 at 19:52, Sasha Levin <sashal@kernel.org> wrote:
>
> I'm sorry, this is my bad: I haven't realized anyone else will be
> looking at these results...
>
> Naresh, I'm cheating and using this tree to bisect the issue you've
> originally reported in
> https://lore.kernel.org/all/CA+G9fYvcBvbabg+m7brKfpGCGZUcK+KHHTFX7hFvW6GmN2XF0g@mail.gmail.com/
> .

Thanks for providing the details of the issue that you are bisecting.

> It seems we can't get traction to get it fixes, so I'm trying to make
> forward progress.
>
> Please ignore linus-next for the next day or two :)

Alright !

- Naresh