From: Namhyung Kim <namhyung@kernel.org>
To: James Clark <james.clark@linaro.org>
Cc: linux-perf-users@vger.kernel.org, acme@kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Howard Chu <howardchu95@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf test trace_btf_general: Fix shellcheck warning
Date: Mon, 6 Jan 2025 13:47:15 -0800 [thread overview]
Message-ID: <Z3xPY-z0uXQNy6a3@google.com> (raw)
In-Reply-To: <20250106164300.734202-1-james.clark@linaro.org>
On Mon, Jan 06, 2025 at 04:42:58PM +0000, James Clark wrote:
> Shellcheck versions < v0.7.2 can't follow this path so add the helper to
> fix the following warning:
>
> tests/shell/trace_btf_general.sh line 8:
> . "$(dirname $0)"/lib/probe.sh
> ^--------------------------^ SC1090: Can't follow non-constant source.
> Use a directive to specify location.
>
> Fixes: 0255338d6975 ("perf trace: Add tests for BTF general augmentation")
> Signed-off-by: James Clark <james.clark@linaro.org>
> ---
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> tools/perf/tests/shell/trace_btf_general.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/tests/shell/trace_btf_general.sh b/tools/perf/tests/shell/trace_btf_general.sh
> index 005c93e6c770..e9ee727f3433 100755
> --- a/tools/perf/tests/shell/trace_btf_general.sh
> +++ b/tools/perf/tests/shell/trace_btf_general.sh
> @@ -5,6 +5,7 @@
> err=0
> set -e
>
> +# shellcheck source=lib/probe.sh
> . "$(dirname $0)"/lib/probe.sh
>
> file1=$(mktemp /tmp/file1_XXXX)
> --
> 2.34.1
>
prev parent reply other threads:[~2025-01-06 21:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 16:42 [PATCH] perf test trace_btf_general: Fix shellcheck warning James Clark
2025-01-06 21:47 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3xPY-z0uXQNy6a3@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=howardchu95@gmail.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox