* [PATCH] perf test trace_btf_general: Fix shellcheck warning
@ 2025-01-06 16:42 James Clark
2025-01-06 21:47 ` Namhyung Kim
0 siblings, 1 reply; 2+ messages in thread
From: James Clark @ 2025-01-06 16:42 UTC (permalink / raw)
To: linux-perf-users, namhyung, acme
Cc: James Clark, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
Liang, Kan, Howard Chu, linux-kernel
Shellcheck versions < v0.7.2 can't follow this path so add the helper to
fix the following warning:
tests/shell/trace_btf_general.sh line 8:
. "$(dirname $0)"/lib/probe.sh
^--------------------------^ SC1090: Can't follow non-constant source.
Use a directive to specify location.
Fixes: 0255338d6975 ("perf trace: Add tests for BTF general augmentation")
Signed-off-by: James Clark <james.clark@linaro.org>
---
tools/perf/tests/shell/trace_btf_general.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/tests/shell/trace_btf_general.sh b/tools/perf/tests/shell/trace_btf_general.sh
index 005c93e6c770..e9ee727f3433 100755
--- a/tools/perf/tests/shell/trace_btf_general.sh
+++ b/tools/perf/tests/shell/trace_btf_general.sh
@@ -5,6 +5,7 @@
err=0
set -e
+# shellcheck source=lib/probe.sh
. "$(dirname $0)"/lib/probe.sh
file1=$(mktemp /tmp/file1_XXXX)
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] perf test trace_btf_general: Fix shellcheck warning
2025-01-06 16:42 [PATCH] perf test trace_btf_general: Fix shellcheck warning James Clark
@ 2025-01-06 21:47 ` Namhyung Kim
0 siblings, 0 replies; 2+ messages in thread
From: Namhyung Kim @ 2025-01-06 21:47 UTC (permalink / raw)
To: James Clark
Cc: linux-perf-users, acme, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
Liang, Kan, Howard Chu, linux-kernel
On Mon, Jan 06, 2025 at 04:42:58PM +0000, James Clark wrote:
> Shellcheck versions < v0.7.2 can't follow this path so add the helper to
> fix the following warning:
>
> tests/shell/trace_btf_general.sh line 8:
> . "$(dirname $0)"/lib/probe.sh
> ^--------------------------^ SC1090: Can't follow non-constant source.
> Use a directive to specify location.
>
> Fixes: 0255338d6975 ("perf trace: Add tests for BTF general augmentation")
> Signed-off-by: James Clark <james.clark@linaro.org>
> ---
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> tools/perf/tests/shell/trace_btf_general.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/tests/shell/trace_btf_general.sh b/tools/perf/tests/shell/trace_btf_general.sh
> index 005c93e6c770..e9ee727f3433 100755
> --- a/tools/perf/tests/shell/trace_btf_general.sh
> +++ b/tools/perf/tests/shell/trace_btf_general.sh
> @@ -5,6 +5,7 @@
> err=0
> set -e
>
> +# shellcheck source=lib/probe.sh
> . "$(dirname $0)"/lib/probe.sh
>
> file1=$(mktemp /tmp/file1_XXXX)
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-06 21:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-06 16:42 [PATCH] perf test trace_btf_general: Fix shellcheck warning James Clark
2025-01-06 21:47 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox