From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Kexy Biscuit <kexybiscuit@aosc.io>
Cc: Huacai Chen <chenhuacai@kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Mingcong Bai <jeffbai@aosc.io>, Icenowy Zheng <uwu@icenowy.me>,
stable@vger.kernel.org
Subject: Re: [PATCH 0/2] MIPS: Loongson64: Remove ROM Size in LEFI boardinfo
Date: Sat, 11 Jan 2025 13:01:43 +0100 [thread overview]
Message-ID: <Z4Jdp2Da+e52Eolb@alpha.franken.de> (raw)
In-Reply-To: <20250111-loongson64-boardinfo-no-size-v1-0-e9f26fcd069e@aosc.io>
On Sat, Jan 11, 2025 at 01:22:07AM +0800, Kexy Biscuit wrote:
> In "MIPS: Loongson64: Add /sys/firmware/lefi/boardinfo", "ROM Size" was
> added under section "BIOS Info". However, that is incorrect per Appendix
> A.7 in Q/LS 0013-2014 (龙芯CPU开发系统固件与内核接口规范 V2.2,
> lit. Loongson DevSys Firmware Kernel Interface Specification V2.2),
> which defines the size to be the size of this interface itself.
>
> Removing "ROM Size" from boardinfo, and also adding comments to the
> struct interface_info to clarify meanings of its members.
>
> Signed-off-by: Kexy Biscuit <kexybiscuit@aosc.io>
> ---
> Kexy Biscuit (2):
> MIPS: Loongson64: remove ROM Size unit in boardinfo
> MIPS: Loongson: Add comments for interface_info
>
> arch/mips/include/asm/mach-loongson64/boot_param.h | 8 ++++----
> arch/mips/loongson64/boardinfo.c | 2 --
> 2 files changed, 4 insertions(+), 6 deletions(-)
> ---
> base-commit: 2144da25584eb10b84252230319b5783f6a83041
> change-id: 20250111-loongson64-boardinfo-no-size-a25dd2a03a8b
series applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2025-01-11 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 17:22 [PATCH 0/2] MIPS: Loongson64: Remove ROM Size in LEFI boardinfo Kexy Biscuit
2025-01-10 17:22 ` [PATCH 1/2] MIPS: Loongson64: remove ROM Size unit in boardinfo Kexy Biscuit
2025-01-10 17:22 ` [PATCH 2/2] MIPS: Loongson: Add comments for interface_info Kexy Biscuit
2025-01-10 18:01 ` [PATCH 0/2] MIPS: Loongson64: Remove ROM Size in LEFI boardinfo Jiaxun Yang
2025-01-11 12:01 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4Jdp2Da+e52Eolb@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=chenhuacai@kernel.org \
--cc=jeffbai@aosc.io \
--cc=jiaxun.yang@flygoat.com \
--cc=kexybiscuit@aosc.io \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=uwu@icenowy.me \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox