[PATCH 0/2] MIPS: Loongson64: Remove ROM Size in LEFI boardinfo

[PATCH 0/2] MIPS: Loongson64: Remove ROM Size in LEFI boardinfo

[Kexy Biscuit]

In "MIPS: Loongson64: Add /sys/firmware/lefi/boardinfo", "ROM Size" was
added under section "BIOS Info". However, that is incorrect per Appendix
A.7 in Q/LS 0013-2014 (龙芯CPU开发系统固件与内核接口规范 V2.2,
lit. Loongson DevSys Firmware Kernel Interface Specification V2.2),
which defines the size to be the size of this interface itself.

Removing "ROM Size" from boardinfo, and also adding comments to the
struct interface_info to clarify meanings of its members.

Signed-off-by: Kexy Biscuit <kexybiscuit@aosc.io>
---
Kexy Biscuit (2):
      MIPS: Loongson64: remove ROM Size unit in boardinfo
      MIPS: Loongson: Add comments for interface_info

 arch/mips/include/asm/mach-loongson64/boot_param.h | 8 ++++----
 arch/mips/loongson64/boardinfo.c                   | 2 --
 2 files changed, 4 insertions(+), 6 deletions(-)
---
base-commit: 2144da25584eb10b84252230319b5783f6a83041
change-id: 20250111-loongson64-boardinfo-no-size-a25dd2a03a8b

Best regards,
-- 
Kexy Biscuit <kexybiscuit@aosc.io>

[PATCH 1/2] MIPS: Loongson64: remove ROM Size unit in boardinfo

[Kexy Biscuit]

Per Appendix A.7 in Q/LS 0013-2014 (龙芯CPU开发系统固件与内核接口规范 V2.2,
lit. Loongson DevSys Firmware Kernel Interface Specification V2.2),
interface_info.size is size of this interface, not size of the LEFI BIOS
ROM.

In any case, the BIOS ROM Size just cannot be several kilobytes (KB) on
Loongson64 LEFI platforms.

Reported-by: Mingcong Bai <jeffbai@aosc.io>
Suggested-by: Icenowy Zheng <uwu@icenowy.me>
Fixes: 6c1bfbd9df8c ("MIPS: Loongson64: Add /sys/firmware/lefi/boardinfo")
Cc: stable@vger.kernel.org
Signed-off-by: Kexy Biscuit <kexybiscuit@aosc.io>
---
 arch/mips/loongson64/boardinfo.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/mips/loongson64/boardinfo.c b/arch/mips/loongson64/boardinfo.c
index 280989c5a137b5f32708b21331b48bc581745130..8bb275c93ac0991c77827404d0c76cf97201a1a8 100644
--- a/arch/mips/loongson64/boardinfo.c
+++ b/arch/mips/loongson64/boardinfo.c
@@ -21,13 +21,11 @@ static ssize_t boardinfo_show(struct kobject *kobj,
 		       "BIOS Info\n"
 		       "Vendor\t\t\t: %s\n"
 		       "Version\t\t\t: %s\n"
-		       "ROM Size\t\t: %d KB\n"
 		       "Release Date\t\t: %s\n",
 		       strsep(&tmp_board_manufacturer, "-"),
 		       eboard->name,
 		       strsep(&tmp_bios_vendor, "-"),
 		       einter->description,
-		       einter->size,
 		       especial->special_name);
 }
 static struct kobj_attribute boardinfo_attr = __ATTR(boardinfo, 0444,

-- 
2.48.0.rc2

[PATCH 2/2] MIPS: Loongson: Add comments for interface_info

[Kexy Biscuit]

Clarify meanings of members of interface_info, especially for .size,
which does not define the ROM size.

Suggested-by: Icenowy Zheng <uwu@icenowy.me>
Signed-off-by: Kexy Biscuit <kexybiscuit@aosc.io>
---
 arch/mips/include/asm/mach-loongson64/boot_param.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/mips/include/asm/mach-loongson64/boot_param.h b/arch/mips/include/asm/mach-loongson64/boot_param.h
index 9218b3ae338322d3cce47421c48d737c93858398..3a11ce85762be626a557ae867e5ee427ea355524 100644
--- a/arch/mips/include/asm/mach-loongson64/boot_param.h
+++ b/arch/mips/include/asm/mach-loongson64/boot_param.h
@@ -128,10 +128,10 @@ struct irq_source_routing_table {
 } __packed;
 
 struct interface_info {
-	u16 vers; /* version of the specificition */
-	u16 size;
-	u8  flag;
-	char description[64];
+	u16 vers; /* version of the specification */
+	u16 size; /* size of this interface */
+	u8  flag; /* used or unused */
+	char description[64]; /* description for each change */
 } __packed;
 
 #define MAX_RESOURCE_NUMBER 128

-- 
2.48.0.rc2

Re: [PATCH 0/2] MIPS: Loongson64: Remove ROM Size in LEFI boardinfo

[Jiaxun Yang]

在2025年1月10日一月 下午5:22，Kexy Biscuit写道：
> In "MIPS: Loongson64: Add /sys/firmware/lefi/boardinfo", "ROM Size" was
> added under section "BIOS Info". However, that is incorrect per Appendix
> A.7 in Q/LS 0013-2014 (龙芯CPU开发系统固件与内核接口规范 V2.2,
> lit. Loongson DevSys Firmware Kernel Interface Specification V2.2),
> which defines the size to be the size of this interface itself.
>
> Removing "ROM Size" from boardinfo, and also adding comments to the
> struct interface_info to clarify meanings of its members.
>
> Signed-off-by: Kexy Biscuit <kexybiscuit@aosc.io>

For the series:

Acked-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Good catch, thanks!

> ---
> Kexy Biscuit (2):
>       MIPS: Loongson64: remove ROM Size unit in boardinfo
>       MIPS: Loongson: Add comments for interface_info
>
>  arch/mips/include/asm/mach-loongson64/boot_param.h | 8 ++++----
>  arch/mips/loongson64/boardinfo.c                   | 2 --
>  2 files changed, 4 insertions(+), 6 deletions(-)
> ---
> base-commit: 2144da25584eb10b84252230319b5783f6a83041
> change-id: 20250111-loongson64-boardinfo-no-size-a25dd2a03a8b
>
> Best regards,
> -- 
> Kexy Biscuit <kexybiscuit@aosc.io>

-- 
- Jiaxun

Re: [PATCH 0/2] MIPS: Loongson64: Remove ROM Size in LEFI boardinfo

[Thomas Bogendoerfer]

On Sat, Jan 11, 2025 at 01:22:07AM +0800, Kexy Biscuit wrote:
> In "MIPS: Loongson64: Add /sys/firmware/lefi/boardinfo", "ROM Size" was
> added under section "BIOS Info". However, that is incorrect per Appendix
> A.7 in Q/LS 0013-2014 (龙芯CPU开发系统固件与内核接口规范 V2.2,
> lit. Loongson DevSys Firmware Kernel Interface Specification V2.2),
> which defines the size to be the size of this interface itself.
> 
> Removing "ROM Size" from boardinfo, and also adding comments to the
> struct interface_info to clarify meanings of its members.
> 
> Signed-off-by: Kexy Biscuit <kexybiscuit@aosc.io>
> ---
> Kexy Biscuit (2):
>       MIPS: Loongson64: remove ROM Size unit in boardinfo
>       MIPS: Loongson: Add comments for interface_info
> 
>  arch/mips/include/asm/mach-loongson64/boot_param.h | 8 ++++----
>  arch/mips/loongson64/boardinfo.c                   | 2 --
>  2 files changed, 4 insertions(+), 6 deletions(-)
> ---
> base-commit: 2144da25584eb10b84252230319b5783f6a83041
> change-id: 20250111-loongson64-boardinfo-no-size-a25dd2a03a8b

series applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]