public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	"mkoutny@suse.com" <mkoutny@suse.com>,
	"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Waiman Long <llong@redhat.com>
Subject: Re: [PATCH v2] Documentation/cgroup-v2: Update memory.{stat,numa_stat} description to reflect possible units
Date: Thu, 16 Jan 2025 07:19:12 -1000	[thread overview]
Message-ID: <Z4k_kLW_a_D50v1I@slm.duckdns.org> (raw)
In-Reply-To: <4e96a241-a996-4289-9ac5-dc1ff65cbff8@fujitsu.com>

Hello,

On Thu, Jan 16, 2025 at 05:50:54AM +0000, Zhijian Li (Fujitsu) wrote:
...
> Let me quote a piece of the numa.stat:
> 
> In pages:
> >          pgdemote_khugepaged                                                   
> >                Number of pages demoted by khugepaged.

If this is the only entry in pages, I'm not sure the proposed document
update is the best one. The above can have an easy alternative description
"the number of times khugepaged demoted a huge page" - ie. indicate that it
is an event counter instead, which is a plausible and likely more intuitive
definition anyway given that a "huge page" can plausibly be of different
sizes. With the key name and matching description, I'm not sure it's
violating the rule that all *sizes* are expressed in bytes.

Thanks.

-- 
tejun

  parent reply	other threads:[~2025-01-16 17:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 12:30 [PATCH] Documentation/cgroup-v2: Update memory.numa_stat description to reflect possible units Li Zhijian
2025-01-10 15:26 ` Waiman Long
2025-01-10 15:35   ` Michal Koutný
2025-01-13  0:38     ` Zhijian Li (Fujitsu)
2025-01-13  1:05 ` [PATCH v2] Documentation/cgroup-v2: Update memory.{stat,numa_stat} " Li Zhijian
2025-01-13  8:58   ` Bagas Sanjaya
2025-01-13 17:49   ` Jonathan Corbet
2025-01-16  5:50     ` Zhijian Li (Fujitsu)
2025-01-16 15:12       ` Jonathan Corbet
2025-01-16 17:19       ` Tejun Heo [this message]
2025-01-17  3:09         ` Zhijian Li (Fujitsu)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z4k_kLW_a_D50v1I@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=hannes@cmpxchg.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizhijian@fujitsu.com \
    --cc=llong@redhat.com \
    --cc=mkoutny@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox