public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Waiman Long <llong@redhat.com>
To: Li Zhijian <lizhijian@fujitsu.com>, linux-doc@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
	mkoutny@suse.com, Jonathan Corbet <corbet@lwn.net>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation/cgroup-v2: Update memory.numa_stat description to reflect possible units
Date: Fri, 10 Jan 2025 10:26:40 -0500	[thread overview]
Message-ID: <a8d5ded2-6921-4c6b-890d-17227147c28d@redhat.com> (raw)
In-Reply-To: <20250110123019.423725-1-lizhijian@fujitsu.com>


On 1/10/25 7:30 AM, Li Zhijian wrote:
> The description of the memory.numa_stat file has been updated to clarify
> that the output values can be in bytes or pages. This change ensures that
> users are aware that the unit of measurement for memory values can vary
> and should be verified by consulting the memory.stat
>
> It's known that
> workingset_*, pgdemote_* and pgpromote_success are counted in pages
>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
>   Documentation/admin-guide/cgroup-v2.rst | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 315ede811c9d..5d1d44547409 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1427,7 +1427,7 @@ The following nested keys are defined.
>   	types of memory, type-specific details, and other information
>   	on the state and past events of the memory management system.
>   
> -	All memory amounts are in bytes.
> +	All memory amounts are in bytes or bytes.

You mean "bytes or pages". Right?

Cheers,
Longman


  reply	other threads:[~2025-01-10 15:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 12:30 [PATCH] Documentation/cgroup-v2: Update memory.numa_stat description to reflect possible units Li Zhijian
2025-01-10 15:26 ` Waiman Long [this message]
2025-01-10 15:35   ` Michal Koutný
2025-01-13  0:38     ` Zhijian Li (Fujitsu)
2025-01-13  1:05 ` [PATCH v2] Documentation/cgroup-v2: Update memory.{stat,numa_stat} " Li Zhijian
2025-01-13  8:58   ` Bagas Sanjaya
2025-01-13 17:49   ` Jonathan Corbet
2025-01-16  5:50     ` Zhijian Li (Fujitsu)
2025-01-16 15:12       ` Jonathan Corbet
2025-01-16 17:19       ` Tejun Heo
2025-01-17  3:09         ` Zhijian Li (Fujitsu)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8d5ded2-6921-4c6b-890d-17227147c28d@redhat.com \
    --to=llong@redhat.com \
    --cc=cgroups@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=hannes@cmpxchg.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizhijian@fujitsu.com \
    --cc=mkoutny@suse.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox