From: Benson Leung <bleung@google.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
chrome-platform@lists.linux.dev, linux-watchdog@vger.kernel.org,
Lukasz Majczak <lma@chromium.org>,
Benson Leung <bleung@chromium.org>
Subject: Re: [PATCH] watchdog: cros-ec: Add newlines to printks
Date: Thu, 16 Jan 2025 22:58:46 +0000 [thread overview]
Message-ID: <Z4mPJmbBXqXkfoX8@google.com> (raw)
In-Reply-To: <20250116224605.110870-1-swboyd@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 2685 bytes --]
On Thu, Jan 16, 2025 at 02:46:04PM -0800, Stephen Boyd wrote:
> Add newlines to printk messages so that the next record is more easily
> readable.
>
> Cc: Lukasz Majczak <lma@chromium.org>
> Cc: Benson Leung <bleung@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
> ---
> drivers/watchdog/cros_ec_wdt.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/watchdog/cros_ec_wdt.c b/drivers/watchdog/cros_ec_wdt.c
> index ba045e29f9a5..716c23f4388c 100644
> --- a/drivers/watchdog/cros_ec_wdt.c
> +++ b/drivers/watchdog/cros_ec_wdt.c
> @@ -58,7 +58,7 @@ static int cros_ec_wdt_ping(struct watchdog_device *wdd)
> arg.req.command = EC_HANG_DETECT_CMD_RELOAD;
> ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
> if (ret < 0)
> - dev_dbg(wdd->parent, "Failed to ping watchdog (%d)", ret);
> + dev_dbg(wdd->parent, "Failed to ping watchdog (%d)\n", ret);
>
> return ret;
> }
> @@ -74,7 +74,7 @@ static int cros_ec_wdt_start(struct watchdog_device *wdd)
> arg.req.reboot_timeout_sec = wdd->timeout;
> ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
> if (ret < 0)
> - dev_dbg(wdd->parent, "Failed to start watchdog (%d)", ret);
> + dev_dbg(wdd->parent, "Failed to start watchdog (%d)\n", ret);
>
> return ret;
> }
> @@ -88,7 +88,7 @@ static int cros_ec_wdt_stop(struct watchdog_device *wdd)
> arg.req.command = EC_HANG_DETECT_CMD_CANCEL;
> ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
> if (ret < 0)
> - dev_dbg(wdd->parent, "Failed to stop watchdog (%d)", ret);
> + dev_dbg(wdd->parent, "Failed to stop watchdog (%d)\n", ret);
>
> return ret;
> }
> @@ -136,7 +136,7 @@ static int cros_ec_wdt_probe(struct platform_device *pdev)
> arg.req.command = EC_HANG_DETECT_CMD_GET_STATUS;
> ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
> if (ret < 0)
> - return dev_err_probe(dev, ret, "Failed to get watchdog bootstatus");
> + return dev_err_probe(dev, ret, "Failed to get watchdog bootstatus\n");
>
> wdd->parent = &pdev->dev;
> wdd->info = &cros_ec_wdt_ident;
> @@ -150,7 +150,7 @@ static int cros_ec_wdt_probe(struct platform_device *pdev)
> arg.req.command = EC_HANG_DETECT_CMD_CLEAR_STATUS;
> ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
> if (ret < 0)
> - return dev_err_probe(dev, ret, "Failed to clear watchdog bootstatus");
> + return dev_err_probe(dev, ret, "Failed to clear watchdog bootstatus\n");
>
> watchdog_stop_on_reboot(wdd);
> watchdog_stop_on_unregister(wdd);
>
> base-commit: 5bc55a333a2f7316b58edc7573e8e893f7acb532
> --
> https://chromeos.dev
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2025-01-16 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 22:46 [PATCH] watchdog: cros-ec: Add newlines to printks Stephen Boyd
2025-01-16 22:54 ` Guenter Roeck
2025-01-16 22:58 ` Benson Leung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4mPJmbBXqXkfoX8@google.com \
--to=bleung@google.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lma@chromium.org \
--cc=patches@lists.linux.dev \
--cc=swboyd@chromium.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox