From: Andrea Righi <arighi@nvidia.com>
To: Changwoo Min <changwoo@igalia.com>
Cc: tj@kernel.org, void@manifault.com, kernel-dev@igalia.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] sched_ext: Implement event counter infrastructure and add an event
Date: Fri, 17 Jan 2025 10:49:55 +0100 [thread overview]
Message-ID: <Z4onw2iub2y1crPC@gpd3> (raw)
In-Reply-To: <20250116151543.80163-2-changwoo@igalia.com>
On Fri, Jan 17, 2025 at 12:15:37AM +0900, Changwoo Min wrote:
...
> +/*
> + * The event counter is organized by a per-CPU variable to minimize the
> + * accounting overhead without synchronization. A system-wide view on the
> + * event counter is constructed when requested by scx_bpf_get_event_stat().
> + */
> +static DEFINE_PER_CPU(struct scx_event_stat, event_stats);
Should we consider tracking these statistics per-scheduler rather than
globally (like adding scx_event_stat to sched_ext_ops)?
It's not particularly important for now, but in the future, if we allow
multiple scx schedulers to be loaded at the same time, tracking separate
stats per-scheduler would be preferable.
Thanks,
-Andrea
next prev parent reply other threads:[~2025-01-17 9:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 15:15 [PATCH 0/7] sched_ext: Implement core event counters Changwoo Min
2025-01-16 15:15 ` [PATCH 1/7] sched_ext: Implement event counter infrastructure and add an event Changwoo Min
2025-01-17 1:33 ` Tejun Heo
2025-01-17 7:08 ` Changwoo Min
2025-01-17 16:24 ` Tejun Heo
2025-01-18 0:27 ` Changwoo Min
2025-01-22 0:42 ` Tejun Heo
2025-01-22 1:37 ` Changwoo Min
2025-01-17 9:49 ` Andrea Righi [this message]
2025-01-17 16:26 ` Tejun Heo
2025-01-18 0:00 ` Changwoo Min
2025-01-21 15:00 ` Leonardo Temperanza
2025-01-22 1:45 ` Changwoo Min
2025-01-16 15:15 ` [PATCH 2/7] sched_ext: Add an event, SCX_EVENT_OFFLINE_LOCAL_DSQ Changwoo Min
2025-01-17 1:37 ` Tejun Heo
2025-01-17 7:11 ` Changwoo Min
2025-01-16 15:15 ` [PATCH 3/7] sched_ext: Add an event, SCX_EVENT_CNTD_RUN_WO_ENQ Changwoo Min
2025-01-17 1:39 ` Tejun Heo
2025-01-17 7:12 ` Changwoo Min
2025-01-16 15:15 ` [PATCH 4/7] sched_ext: Add an event, SCX_EVENT_ENQ_LOCAL_EXITING Changwoo Min
2025-01-17 1:40 ` Tejun Heo
2025-01-17 7:12 ` Changwoo Min
2025-01-16 15:15 ` [PATCH 5/7] sched_ext: Add an event, SCX_EVENT_RQ_BYPASSING_OPS Changwoo Min
2025-01-17 1:41 ` Tejun Heo
2025-01-17 7:31 ` Changwoo Min
2025-01-17 16:14 ` Tejun Heo
2025-01-16 15:15 ` [PATCH 6/7] sched_ext: Add scx_bpf_event_stat() and scx_read_event() for BPF schedulers Changwoo Min
2025-01-16 15:15 ` [PATCH 7/7] sched_ext: Print core event count in scx_central scheduler Changwoo Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4onw2iub2y1crPC@gpd3 \
--to=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox