From: Andrea Righi <arighi@nvidia.com>
To: Breno Leitao <leitao@debian.org>
Cc: Tejun Heo <tj@kernel.org>, David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [PATCH] sched_ext: Fix potential deadlock in destroy_dsq()
Date: Fri, 17 Jan 2025 10:55:03 +0100 [thread overview]
Message-ID: <Z4oo9_SXein4BDnD@gpd3> (raw)
In-Reply-To: <20250117-defiant-tidy-foxhound-3bcbc2@leitao>
Hi Breno,
On Fri, Jan 17, 2025 at 01:46:12AM -0800, Breno Leitao wrote:
...
> > Hmm... this is probably the same thing that Breno tried to fix with
> > rhashtable update. Breno, what's the current state of that patch? I saw bug
> > reports and fix patch flying by but didn't track them closely.
>
> Right, that seems exactly the problem I fixed. This is the current state
> of the issue.
>
> The fix is already in linux-next, but not on linus' tree:
>
> e1d3422c95f00 Breno Leitao : rhashtable: Fix potential deadlock by moving schedule_work outside lock
Oh I totally missed your fix.
>
> That fixes caused a regression[1], and Herbert got a patch, which is not
> committed in linux-next AFAIK.
>
> This is Herbert's fix:
>
> https://lore.kernel.org/all/Z4XWx5X0doetOJni@gondor.apana.org.au/
If there's something in progress already, feel free to ignore my patch.
I'll do a test on my side later with these fixes applied.
Thanks,
-Andrea
>
> [1] Link: https://lore.kernel.org/all/Z4DoFYQ3ytB-wS3-@gondor.apana.org.au/
>
> --breno
prev parent reply other threads:[~2025-01-17 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 11:51 [PATCH] sched_ext: Fix potential deadlock in destroy_dsq() Andrea Righi
2025-01-17 2:06 ` Tejun Heo
2025-01-17 9:46 ` Breno Leitao
2025-01-17 9:55 ` Andrea Righi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4oo9_SXein4BDnD@gpd3 \
--to=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=herbert@gondor.apana.org.au \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox