* [PATCH RESEND] drm/komeda: Add check for komeda_get_layer_fourcc_list()
@ 2024-12-19 9:02 Haoxiang Li
2025-01-22 11:28 ` Liviu Dudau
0 siblings, 1 reply; 2+ messages in thread
From: Haoxiang Li @ 2024-12-19 9:02 UTC (permalink / raw)
To: liviu.dudau, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, james.qian.wang, ayan.halder
Cc: dri-devel, linux-kernel, Haoxiang Li, stable
Add check for the return value of komeda_get_layer_fourcc_list()
to catch the potential exception.
Fixes: 5d51f6c0da1b ("drm/komeda: Add writeback support")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
index ebccb74306a7..f30b3d5eeca5 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
@@ -160,6 +160,10 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms,
formats = komeda_get_layer_fourcc_list(&mdev->fmt_tbl,
kwb_conn->wb_layer->layer_type,
&n_formats);
+ if (!formats) {
+ kfree(kwb_conn);
+ return -ENOMEM;
+ }
err = drm_writeback_connector_init(&kms->base, wb_conn,
&komeda_wb_connector_funcs,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH RESEND] drm/komeda: Add check for komeda_get_layer_fourcc_list()
2024-12-19 9:02 [PATCH RESEND] drm/komeda: Add check for komeda_get_layer_fourcc_list() Haoxiang Li
@ 2025-01-22 11:28 ` Liviu Dudau
0 siblings, 0 replies; 2+ messages in thread
From: Liviu Dudau @ 2025-01-22 11:28 UTC (permalink / raw)
To: Haoxiang Li
Cc: liviu.dudau, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, james.qian.wang, ayan.halder, dri-devel, linux-kernel,
stable
Hi Haoxiang,
For reasons that I have not uncovered yet, the work email servers never
delivered your message, I have discovered it today accidentally while
looking in a backup I have at home.
On Thu, Dec 19, 2024 at 05:02:56PM +0800, Haoxiang Li wrote:
> Add check for the return value of komeda_get_layer_fourcc_list()
> to catch the potential exception.
>
> Fixes: 5d51f6c0da1b ("drm/komeda: Add writeback support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> index ebccb74306a7..f30b3d5eeca5 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> @@ -160,6 +160,10 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms,
> formats = komeda_get_layer_fourcc_list(&mdev->fmt_tbl,
> kwb_conn->wb_layer->layer_type,
> &n_formats);
> + if (!formats) {
> + kfree(kwb_conn);
> + return -ENOMEM;
> + }
>
> err = drm_writeback_connector_init(&kms->base, wb_conn,
> &komeda_wb_connector_funcs,
> --
> 2.25.1
>
--
Everyone who uses computers frequently has had, from time to time,
a mad desire to attack the precocious abacus with an axe.
-- John D. Clark, Ignition!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-22 11:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-19 9:02 [PATCH RESEND] drm/komeda: Add check for komeda_get_layer_fourcc_list() Haoxiang Li
2025-01-22 11:28 ` Liviu Dudau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox