From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] kthread: Return the assigned value rather than 0
Date: Fri, 7 Feb 2025 16:40:14 +0200 [thread overview]
Message-ID: <Z6YbTgpbimhonft2@black.fi.intel.com> (raw)
In-Reply-To: <Z6IkFec26HmiwM4H@smile.fi.intel.com>
On Tue, Feb 04, 2025 at 04:28:37PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 04, 2025 at 01:45:13AM +0100, Frederic Weisbecker wrote:
> > Le Mon, Feb 03, 2025 at 06:48:55PM +0200, Andy Shevchenko a écrit :
> > > Recently introduced kthread_affine_preferred() has a bug that the value
> > > of ret variable set but not used. This breaks the compilation with error
> > > (assume default CONFIG_WERROR=y and `make W=1` to run the build):
> > >
> > > kernel/kthread.c:862:6: error: variable 'ret' set but not used [-Werror,-Wunused-but-set-variable]
> > >
> > > Fixes: 4d13f4304fa4 ("kthread: Implement preferred affinity")
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Thanks but I already have it queued there:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git/commit/?h=kthread/fixes&id=1b0332a42656b798bea867631d739de023633ec6
> >
> > I'll do a pull request shortly.
>
> I'm fine with any approach as long as the issue will be fixed rather sooner.
Any news? As of today no appearance of the (alternative) fix either in upstream,
or in Linux Next. What's the plan, please?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-02-07 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 16:48 [PATCH v1 1/1] kthread: Return the assigned value rather than 0 Andy Shevchenko
2025-02-04 0:45 ` Frederic Weisbecker
2025-02-04 14:28 ` Andy Shevchenko
2025-02-07 14:40 ` Andy Shevchenko [this message]
2025-02-07 18:32 ` Frederic Weisbecker
2025-02-07 19:02 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6YbTgpbimhonft2@black.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox