From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 3/3] gpiolib: don't double-check the gc->get callback's existence
Date: Tue, 25 Feb 2025 15:20:39 +0200 [thread overview]
Message-ID: <Z73Dp5EH3sHMZDZ7@smile.fi.intel.com> (raw)
In-Reply-To: <20250225-retval-fixes-v1-3-078c4c98517a@linaro.org>
On Tue, Feb 25, 2025 at 12:56:25PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> gpiochip_get() is called only in two places: in gpio_chip_get_value()
> and in gpiochip_get_multiple() where the existence of the gc->get()
> callback is already checked. It makes sense to unduplicate the check by
> moving it one level up the stack.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-02-25 13:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 11:56 [PATCH 0/3] gpiolib: fix bugs in retval sanitization Bartosz Golaszewski
2025-02-25 11:56 ` [PATCH 1/3] gpiolib: don't use gpiochip_get_direction() when registering a chip Bartosz Golaszewski
2025-02-25 13:22 ` Marek Szyprowski
2025-02-25 13:22 ` Andy Shevchenko
2025-02-25 14:43 ` Bartosz Golaszewski
2025-02-25 14:46 ` Andy Shevchenko
2025-02-25 11:56 ` [PATCH 2/3] gpiolib: use a more explicit retval logic in gpiochip_get_direction() Bartosz Golaszewski
2025-02-25 13:19 ` Andy Shevchenko
2025-02-25 11:56 ` [PATCH 3/3] gpiolib: don't double-check the gc->get callback's existence Bartosz Golaszewski
2025-02-25 13:20 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z73Dp5EH3sHMZDZ7@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox