Re: [PATCH] vgaarbiter: documentation grammar correction

Re: [PATCH] vgaarbiter: documentation grammar correction

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 2071 bytes --]

On Fri, Feb 07, 2025 at 10:23:25PM +0530, Pranav Tyagi wrote:
> Corrects the following grammatical issues in the VGA Arbiter documentation:
> - Fixes subject-verb agreement by changing "co-exists" to "co-exist"
> - Corrects pluralization by changing "server" to "servers"
> - Improves sentence structure for clarity
> 

+Cc: DRM folks.

> Signed-off-by: Pranav Tyagi <pranav.tyagi03@gmail.com>
> ---
>  Documentation/gpu/vgaarbiter.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/gpu/vgaarbiter.rst b/Documentation/gpu/vgaarbiter.rst
> index bde3c0afb059..d1e953712cc2 100644
> --- a/Documentation/gpu/vgaarbiter.rst
> +++ b/Documentation/gpu/vgaarbiter.rst
> @@ -11,9 +11,9 @@ Section 7, Legacy Devices.
>  
>  The Resource Access Control (RAC) module inside the X server [0] existed for
>  the legacy VGA arbitration task (besides other bus management tasks) when more
> -than one legacy device co-exists on the same machine. But the problem happens
> +than one legacy device co-exist on the same machine. But the problem happens
>  when these devices are trying to be accessed by different userspace clients
> -(e.g. two server in parallel). Their address assignments conflict. Moreover,
> +(e.g. two servers in parallel). Their address assignments conflict. Moreover,
>  ideally, being a userspace application, it is not the role of the X server to
>  control bus resources. Therefore an arbitration scheme outside of the X server
>  is needed to control the sharing of these resources. This document introduces
> @@ -106,7 +106,7 @@ In-kernel interface
>  libpciaccess
>  ------------
>  
> -To use the vga arbiter char device it was implemented an API inside the
> +To use the vga arbiter char device, an API was implemented inside the
>  libpciaccess library. One field was added to struct pci_device (each device
>  on the system)::
>  

The diff looks OK.

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] vgaarbiter: documentation grammar correction

[Pranav Tyagi]

Hi,

Just a gentle follow-up on this patch. It has been reviewed but hasn't
been applied yet.

Regards
Pranav Tyagi


On Thu, Feb 13, 2025 at 10:54 PM Pranav Tyagi <pranav.tyagi03@gmail.com> wrote:
>
> Hi,
>
> Just a gentle follow-up on this patch. It has been reviewed by Bagas Sanjaya but hasn't been applied yet.
>
> Regards,
>
> Pranav Tyagi
>
>
> On Sat, Feb 8, 2025 at 8:36 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>>
>> On Fri, Feb 07, 2025 at 10:23:25PM +0530, Pranav Tyagi wrote:
>> > Corrects the following grammatical issues in the VGA Arbiter documentation:
>> > - Fixes subject-verb agreement by changing "co-exists" to "co-exist"
>> > - Corrects pluralization by changing "server" to "servers"
>> > - Improves sentence structure for clarity
>> >
>>
>> +Cc: DRM folks.
>>
>> > Signed-off-by: Pranav Tyagi <pranav.tyagi03@gmail.com>
>> > ---
>> >  Documentation/gpu/vgaarbiter.rst | 6 +++---
>> >  1 file changed, 3 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/Documentation/gpu/vgaarbiter.rst b/Documentation/gpu/vgaarbiter.rst
>> > index bde3c0afb059..d1e953712cc2 100644
>> > --- a/Documentation/gpu/vgaarbiter.rst
>> > +++ b/Documentation/gpu/vgaarbiter.rst
>> > @@ -11,9 +11,9 @@ Section 7, Legacy Devices.
>> >
>> >  The Resource Access Control (RAC) module inside the X server [0] existed for
>> >  the legacy VGA arbitration task (besides other bus management tasks) when more
>> > -than one legacy device co-exists on the same machine. But the problem happens
>> > +than one legacy device co-exist on the same machine. But the problem happens
>> >  when these devices are trying to be accessed by different userspace clients
>> > -(e.g. two server in parallel). Their address assignments conflict. Moreover,
>> > +(e.g. two servers in parallel). Their address assignments conflict. Moreover,
>> >  ideally, being a userspace application, it is not the role of the X server to
>> >  control bus resources. Therefore an arbitration scheme outside of the X server
>> >  is needed to control the sharing of these resources. This document introduces
>> > @@ -106,7 +106,7 @@ In-kernel interface
>> >  libpciaccess
>> >  ------------
>> >
>> > -To use the vga arbiter char device it was implemented an API inside the
>> > +To use the vga arbiter char device, an API was implemented inside the
>> >  libpciaccess library. One field was added to struct pci_device (each device
>> >  on the system)::
>> >
>>
>> The diff looks OK.
>>
>> Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
>>
>> --
>> An old man doll... just what I always wanted! - Clara

Re: [PATCH] vgaarbiter: documentation grammar correction

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

On Thu, Feb 13, 2025 at 11:05:39PM +0530, Pranav Tyagi wrote:
> Hi,
> 
> Just a gentle follow-up on this patch. It has been reviewed but hasn't
> been applied yet.

You may need to resend the patch, but with scripts/get_maintainer.pl
output Cc'ed so that DRM maintainers can be notified on the patch.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] vgaarbiter: documentation grammar correction

[Simona Vetter]

On Wed, Feb 19, 2025 at 02:56:58PM +0700, Bagas Sanjaya wrote:
> On Thu, Feb 13, 2025 at 11:05:39PM +0530, Pranav Tyagi wrote:
> > Hi,
> > 
> > Just a gentle follow-up on this patch. It has been reviewed but hasn't
> > been applied yet.
> 
> You may need to resend the patch, but with scripts/get_maintainer.pl
> output Cc'ed so that DRM maintainers can be notified on the patch.

I don't have the patch since it wasn't cc'ed to dri-devel. Can you please
resend with r-b tag included?

Thanks, Sima
-- 
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Re: [PATCH] vgaarbiter: documentation grammar correction

[Pranav Tyagi]

On Wed, Feb 19, 2025 at 7:03 PM Simona Vetter <simona.vetter@ffwll.ch> wrote:
>
> On Wed, Feb 19, 2025 at 02:56:58PM +0700, Bagas Sanjaya wrote:
> > On Thu, Feb 13, 2025 at 11:05:39PM +0530, Pranav Tyagi wrote:
> > > Hi,
> > >
> > > Just a gentle follow-up on this patch. It has been reviewed but hasn't
> > > been applied yet.
> >
> > You may need to resend the patch, but with scripts/get_maintainer.pl
> > output Cc'ed so that DRM maintainers can be notified on the patch.
>
> I don't have the patch since it wasn't cc'ed to dri-devel. Can you please
> resend with r-b tag included?
>
> Thanks, Sima
> --
> Simona Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

Hi,

I have sent the patch again to you with the r-b tag included and cc'ed
it to dri-devel aswell.

Regards
Pranav Tyagi