public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Simona Vetter <simona.vetter@ffwll.ch>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Raag Jadav <raag.jadav@intel.com>,
	arnd@arndb.de, andriy.shevchenko@linux.intel.com,
	airlied@gmail.com, simona@ffwll.ch,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] drm/draw: include bug.h
Date: Fri, 21 Feb 2025 10:49:48 +0100	[thread overview]
Message-ID: <Z7hMPIxFyd6cqbC0@phenom.ffwll.local> (raw)
In-Reply-To: <2025022135-aviation-evident-2518@gregkh>

On Fri, Feb 21, 2025 at 07:05:12AM +0100, Greg KH wrote:
> On Fri, Feb 21, 2025 at 10:38:04AM +0530, Raag Jadav wrote:
> > Directly include bug.h for WARN() helpers instead of relying on
> > intermediate headers.
> > 
> > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > ---
> >  drivers/gpu/drm/drm_draw.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_draw.c b/drivers/gpu/drm/drm_draw.c
> > index cb2ad12bce57..0a0e1eebf481 100644
> > --- a/drivers/gpu/drm/drm_draw.c
> > +++ b/drivers/gpu/drm/drm_draw.c
> > @@ -5,6 +5,7 @@
> >   */
> >  
> >  #include <linux/bits.h>
> > +#include <linux/bug.h>
> >  #include <linux/iosys-map.h>
> >  #include <linux/types.h>
> >  
> > -- 
> > 2.34.1
> > 
> 
> Does patch 1 break this file without this patch so this series is not in
> order?
> 
> I'll be glad to take patch 1 in my tree, but I don't want to break
> anything else.

Yeah looks inverted. In case this is all there is I'm happy to land this
patch through your tree, that seems like the simplest approach.

Acked-by: Simona Vetter <simona.vetter@ffwll.ch>

Cheers, Sima
-- 
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

  reply	other threads:[~2025-02-21  9:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21  5:08 [PATCH v2 0/2] Cleanup io.h Raag Jadav
2025-02-21  5:08 ` [PATCH v2 1/2] io.h: drop unused headers Raag Jadav
2025-02-21  5:08 ` [PATCH v2 2/2] drm/draw: include bug.h Raag Jadav
2025-02-21  6:05   ` Greg KH
2025-02-21  9:49     ` Simona Vetter [this message]
2025-02-21 10:24       ` Raag Jadav
2025-02-21 10:15 ` [PATCH v2 0/2] Cleanup io.h Arnd Bergmann
2025-02-21 11:26   ` Raag Jadav
2025-02-21 16:50   ` Andy Shevchenko
2025-02-21 17:15     ` Arnd Bergmann
2025-03-03 10:31       ` Andy Shevchenko
2025-02-21 16:12 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z7hMPIxFyd6cqbC0@phenom.ffwll.local \
    --to=simona.vetter@ffwll.ch \
    --cc=airlied@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raag.jadav@intel.com \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox