* [PATCH] auxdisplay: hd44780: Fix an API misuse in hd44780_remove()
@ 2025-02-24 10:00 Haoxiang Li
2025-02-24 10:32 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Haoxiang Li @ 2025-02-24 10:00 UTC (permalink / raw)
To: andy, geert, haoxiang_li2024, u.kleine-koenig, erick.archer,
ojeda, w, poeschel
Cc: linux-kernel, stable
Fix this by using charlcd_free() instead of kfree().
Fixes: 718e05ed92ec ("auxdisplay: Introduce hd44780_common.[ch]")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
---
drivers/auxdisplay/hd44780.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c
index 0526f0d90a79..fcd3780ce5d1 100644
--- a/drivers/auxdisplay/hd44780.c
+++ b/drivers/auxdisplay/hd44780.c
@@ -328,7 +328,7 @@ static void hd44780_remove(struct platform_device *pdev)
kfree(hdc->hd44780);
kfree(lcd->drvdata);
- kfree(lcd);
+ charlcd_free(lcd);
}
static const struct of_device_id hd44780_of_match[] = {
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] auxdisplay: hd44780: Fix an API misuse in hd44780_remove()
2025-02-24 10:00 [PATCH] auxdisplay: hd44780: Fix an API misuse in hd44780_remove() Haoxiang Li
@ 2025-02-24 10:32 ` Andy Shevchenko
2025-02-24 10:34 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2025-02-24 10:32 UTC (permalink / raw)
To: Haoxiang Li
Cc: geert, u.kleine-koenig, erick.archer, ojeda, w, poeschel,
linux-kernel, stable
On Mon, Feb 24, 2025 at 06:00:09PM +0800, Haoxiang Li wrote:
> Fix this by using charlcd_free() instead of kfree().
Please, fold two patches into one and send it as v2. Thank you!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] auxdisplay: hd44780: Fix an API misuse in hd44780_remove()
2025-02-24 10:32 ` Andy Shevchenko
@ 2025-02-24 10:34 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2025-02-24 10:34 UTC (permalink / raw)
To: Haoxiang Li
Cc: geert, u.kleine-koenig, erick.archer, ojeda, w, poeschel,
linux-kernel, stable
On Mon, Feb 24, 2025 at 12:32:49PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 24, 2025 at 06:00:09PM +0800, Haoxiang Li wrote:
> > Fix this by using charlcd_free() instead of kfree().
>
> Please, fold two patches into one and send it as v2. Thank you!
Ah, I see it now.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-24 10:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-24 10:00 [PATCH] auxdisplay: hd44780: Fix an API misuse in hd44780_remove() Haoxiang Li
2025-02-24 10:32 ` Andy Shevchenko
2025-02-24 10:34 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox