[PATCH v2 0/2] Convert regulator drivers to use devm_kmemdup_array()

[PATCH v2 0/2] Convert regulator drivers to use devm_kmemdup_array()

[Raag Jadav]

This series converts regulator drivers to use the newly introduced[1]
devm_kmemdup_array() helper. This depends on changes available on
immutable tag[2].

[1] https://lore.kernel.org/r/20250212062513.2254767-1-raag.jadav@intel.com
[2] https://lore.kernel.org/r/Z7xGpz3Q4Zj6YHx7@black.fi.intel.com

v2: Split patch series per subsystem

Raag Jadav (2):
  regulator: devres: use devm_kmemdup_array()
  regulator: cros-ec: use devm_kmemdup_array()

 drivers/regulator/cros-ec-regulator.c | 4 ++--
 drivers/regulator/devres.c            | 5 ++---
 2 files changed, 4 insertions(+), 5 deletions(-)


base-commit: b8c38ccb2ca52b9a38cfeb9f89abab5d6e713221
-- 
2.34.1

[PATCH v2 1/2] regulator: devres: use devm_kmemdup_array()

[Raag Jadav]

Convert to use devm_kmemdup_array() which is more robust.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
 drivers/regulator/devres.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/devres.c b/drivers/regulator/devres.c
index 36164aec30e8..ab238579879c 100644
--- a/drivers/regulator/devres.c
+++ b/drivers/regulator/devres.c
@@ -332,9 +332,8 @@ int devm_regulator_bulk_get_const(struct device *dev, int num_consumers,
 				  const struct regulator_bulk_data *in_consumers,
 				  struct regulator_bulk_data **out_consumers)
 {
-	*out_consumers = devm_kmemdup(dev, in_consumers,
-				      num_consumers * sizeof(*in_consumers),
-				      GFP_KERNEL);
+	*out_consumers = devm_kmemdup_array(dev, in_consumers, num_consumers,
+					    sizeof(*in_consumers), GFP_KERNEL);
 	if (*out_consumers == NULL)
 		return -ENOMEM;
 
-- 
2.34.1

[PATCH v2 2/2] regulator: cros-ec: use devm_kmemdup_array()

[Raag Jadav]

Convert to use devm_kmemdup_array() and while at it, make the size robust
against type changes.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
 drivers/regulator/cros-ec-regulator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/cros-ec-regulator.c b/drivers/regulator/cros-ec-regulator.c
index fb9643ed7a49..fb0767b33a36 100644
--- a/drivers/regulator/cros-ec-regulator.c
+++ b/drivers/regulator/cros-ec-regulator.c
@@ -138,8 +138,8 @@ static int cros_ec_regulator_init_info(struct device *dev,
 	data->num_voltages =
 		min_t(u16, ARRAY_SIZE(resp.voltages_mv), resp.num_voltages);
 	data->voltages_mV =
-		devm_kmemdup(dev, resp.voltages_mv,
-			     sizeof(u16) * data->num_voltages, GFP_KERNEL);
+		devm_kmemdup_array(dev, resp.voltages_mv, data->num_voltages,
+				   sizeof(resp.voltages_mv[0]), GFP_KERNEL);
 	if (!data->voltages_mV)
 		return -ENOMEM;
 
-- 
2.34.1

Re: [PATCH v2 0/2] Convert regulator drivers to use devm_kmemdup_array()

[Mark Brown]

On Fri, 28 Feb 2025 12:50:55 +0530, Raag Jadav wrote:
> This series converts regulator drivers to use the newly introduced[1]
> devm_kmemdup_array() helper. This depends on changes available on
> immutable tag[2].
> 
> [1] https://lore.kernel.org/r/20250212062513.2254767-1-raag.jadav@intel.com
> [2] https://lore.kernel.org/r/Z7xGpz3Q4Zj6YHx7@black.fi.intel.com
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/2] regulator: devres: use devm_kmemdup_array()
      commit: 6ddd1159825c516b8f64fda83177c161434141f5
[2/2] regulator: cros-ec: use devm_kmemdup_array()
      commit: c5c4ce6612bb25ce6d6936d8ade96fcba635da54

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH v2 0/2] Convert regulator drivers to use devm_kmemdup_array()

[Raag Jadav]

On Fri, Feb 28, 2025 at 09:22:47PM +0000, Mark Brown wrote:
> On Fri, 28 Feb 2025 12:50:55 +0530, Raag Jadav wrote:
> > This series converts regulator drivers to use the newly introduced[1]
> > devm_kmemdup_array() helper. This depends on changes available on
> > immutable tag[2].
> > 
> > [1] https://lore.kernel.org/r/20250212062513.2254767-1-raag.jadav@intel.com
> > [2] https://lore.kernel.org/r/Z7xGpz3Q4Zj6YHx7@black.fi.intel.com
> > 
> > [...]
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thank you.

Unless there's a nuance intended in the merge series title that I'm unable
to understand, it probably seems incomplete.

Raag

Re: [PATCH v2 0/2] Convert regulator drivers to use devm_kmemdup_array()

[Andy Shevchenko]

On Thu, Mar 06, 2025 at 04:15:55AM +0200, Raag Jadav wrote:
> On Fri, Feb 28, 2025 at 09:22:47PM +0000, Mark Brown wrote:
> > On Fri, 28 Feb 2025 12:50:55 +0530, Raag Jadav wrote:
> > > This series converts regulator drivers to use the newly introduced[1]
> > > devm_kmemdup_array() helper. This depends on changes available on
> > > immutable tag[2].
> > > 
> > > [1] https://lore.kernel.org/r/20250212062513.2254767-1-raag.jadav@intel.com
> > > [2] https://lore.kernel.org/r/Z7xGpz3Q4Zj6YHx7@black.fi.intel.com
> > > 
> > > [...]
> > 
> > Applied to
> > 
> >    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
> 
> Thank you.
> 
> Unless there's a nuance intended in the merge series title that I'm unable
> to understand, it probably seems incomplete.

I believe it's an issue somewhere in the scripts. The long Subject line is
split in the mailbox and that's probably is not supported by the machinery.

You are not the only one who reports this issue.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/2] Convert regulator drivers to use devm_kmemdup_array()

[Raag Jadav]

On Thu, Mar 06, 2025 at 11:19:31AM +0200, Andy Shevchenko wrote:
> On Thu, Mar 06, 2025 at 04:15:55AM +0200, Raag Jadav wrote:
> > On Fri, Feb 28, 2025 at 09:22:47PM +0000, Mark Brown wrote:
> > > On Fri, 28 Feb 2025 12:50:55 +0530, Raag Jadav wrote:
> > > > This series converts regulator drivers to use the newly introduced[1]
> > > > devm_kmemdup_array() helper. This depends on changes available on
> > > > immutable tag[2].
> > > > 
> > > > [1] https://lore.kernel.org/r/20250212062513.2254767-1-raag.jadav@intel.com
> > > > [2] https://lore.kernel.org/r/Z7xGpz3Q4Zj6YHx7@black.fi.intel.com
> > > > 
> > > > [...]
> > > 
> > > Applied to
> > > 
> > >    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
> > 
> > Thank you.
> > 
> > Unless there's a nuance intended in the merge series title that I'm unable
> > to understand, it probably seems incomplete.
> 
> I believe it's an issue somewhere in the scripts. The long Subject line is
> split in the mailbox and that's probably is not supported by the machinery.
> 
> You are not the only one who reports this issue.

While I'm not well educated on the machinery, I'm also seeing devm_kmemdup_array()
introduction commit reordered in -next and thinking perhaps it can cause issues
with bisect, especially after final merge into Linus' tree?

Raag

Re: [PATCH v2 0/2] Convert regulator drivers to use devm_kmemdup_array()

[Andy Shevchenko]

On Thu, Mar 06, 2025 at 12:14:59PM +0200, Raag Jadav wrote:
> On Thu, Mar 06, 2025 at 11:19:31AM +0200, Andy Shevchenko wrote:
> > On Thu, Mar 06, 2025 at 04:15:55AM +0200, Raag Jadav wrote:
> > > On Fri, Feb 28, 2025 at 09:22:47PM +0000, Mark Brown wrote:
> > > > On Fri, 28 Feb 2025 12:50:55 +0530, Raag Jadav wrote:
> > > > > This series converts regulator drivers to use the newly introduced[1]
> > > > > devm_kmemdup_array() helper. This depends on changes available on
> > > > > immutable tag[2].
> > > > > 
> > > > > [1] https://lore.kernel.org/r/20250212062513.2254767-1-raag.jadav@intel.com
> > > > > [2] https://lore.kernel.org/r/Z7xGpz3Q4Zj6YHx7@black.fi.intel.com
> > > > > 
> > > > > [...]
> > > > 
> > > > Applied to
> > > > 
> > > >    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
> > > 
> > > Thank you.
> > > 
> > > Unless there's a nuance intended in the merge series title that I'm unable
> > > to understand, it probably seems incomplete.
> > 
> > I believe it's an issue somewhere in the scripts. The long Subject line is
> > split in the mailbox and that's probably is not supported by the machinery.
> > 
> > You are not the only one who reports this issue.
> 
> While I'm not well educated on the machinery, I'm also seeing devm_kmemdup_array()
> introduction commit reordered in -next and thinking perhaps it can cause issues
> with bisect, especially after final merge into Linus' tree?

I;m not sure what you exactly pointing out here. Mark seems applied only
necessary part of the immutable tag, which have the same effect. The Git merges
only once the stuff as long as it has the same hash.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/2] Convert regulator drivers to use devm_kmemdup_array()

[Raag Jadav]

On Thu, Mar 06, 2025 at 01:04:32PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 06, 2025 at 12:14:59PM +0200, Raag Jadav wrote:
> > On Thu, Mar 06, 2025 at 11:19:31AM +0200, Andy Shevchenko wrote:
> > > On Thu, Mar 06, 2025 at 04:15:55AM +0200, Raag Jadav wrote:
> > > > On Fri, Feb 28, 2025 at 09:22:47PM +0000, Mark Brown wrote:
> > > > > On Fri, 28 Feb 2025 12:50:55 +0530, Raag Jadav wrote:
> > > > > > This series converts regulator drivers to use the newly introduced[1]
> > > > > > devm_kmemdup_array() helper. This depends on changes available on
> > > > > > immutable tag[2].
> > > > > > 
> > > > > > [1] https://lore.kernel.org/r/20250212062513.2254767-1-raag.jadav@intel.com
> > > > > > [2] https://lore.kernel.org/r/Z7xGpz3Q4Zj6YHx7@black.fi.intel.com
> > > > > > 
> > > > > > [...]
> > > > > 
> > > > > Applied to
> > > > > 
> > > > >    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
> > > > 
> > > > Thank you.
> > > > 
> > > > Unless there's a nuance intended in the merge series title that I'm unable
> > > > to understand, it probably seems incomplete.
> > > 
> > > I believe it's an issue somewhere in the scripts. The long Subject line is
> > > split in the mailbox and that's probably is not supported by the machinery.
> > > 
> > > You are not the only one who reports this issue.
> > 
> > While I'm not well educated on the machinery, I'm also seeing devm_kmemdup_array()
> > introduction commit reordered in -next and thinking perhaps it can cause issues
> > with bisect, especially after final merge into Linus' tree?
> 
> I;m not sure what you exactly pointing out here. Mark seems applied only
> necessary part of the immutable tag, which have the same effect. The Git merges
> only once the stuff as long as it has the same hash.

$ git describe
next-20250306

$ git log --oneline --grep raag

...

1f4c7f3b3afa Merge patch series "Split devres APIs to device/devres.h and introduce devm_kmemdup_array()"
a103b833ac38 devres: Introduce devm_kmemdup_array()
b8c38ccb2ca5 input: ipaq-micro-keys: use devm_kmemdup_array()
cdcc09a495a4 input: sparse-keymap: use devm_kmemdup_array()
a0d78eec8839 iio: adc: xilinx-xadc-core: use devm_kmemdup_array()
86068aca7548 pinctrl: pxa2xx: use devm_kmemdup_array()
91bfcc7a2fdb pinctrl: tangier: use devm_kmemdup_array()
d795fb90d6c6 pinctrl: cherryview: use devm_kmemdup_array()
f192c8447f4e pinctrl: baytrail: copy communities using devm_kmemdup_array()
753764aa8eb5 pinctrl: intel: copy communities using devm_kmemdup_array()
a21cad931276 driver core: Split devres APIs to device/devres.h
18311a766c58 err.h: move IOMEM_ERR_PTR() to err.h


I'm expecting commit a103b833ac38 to be before its users, or perhaps I'm
doing something wrong here?

Raag

Re: [PATCH v2 0/2] Convert regulator drivers to use devm_kmemdup_array()

[Andy Shevchenko]

On Thu, Mar 06, 2025 at 01:32:19PM +0200, Raag Jadav wrote:
> On Thu, Mar 06, 2025 at 01:04:32PM +0200, Andy Shevchenko wrote:
> > On Thu, Mar 06, 2025 at 12:14:59PM +0200, Raag Jadav wrote:
> > > On Thu, Mar 06, 2025 at 11:19:31AM +0200, Andy Shevchenko wrote:
> > > > On Thu, Mar 06, 2025 at 04:15:55AM +0200, Raag Jadav wrote:
> > > > > On Fri, Feb 28, 2025 at 09:22:47PM +0000, Mark Brown wrote:
> > > > > > On Fri, 28 Feb 2025 12:50:55 +0530, Raag Jadav wrote:
> > > > > > > This series converts regulator drivers to use the newly introduced[1]
> > > > > > > devm_kmemdup_array() helper. This depends on changes available on
> > > > > > > immutable tag[2].
> > > > > > > 
> > > > > > > [1] https://lore.kernel.org/r/20250212062513.2254767-1-raag.jadav@intel.com
> > > > > > > [2] https://lore.kernel.org/r/Z7xGpz3Q4Zj6YHx7@black.fi.intel.com
> > > > > > > 
> > > > > > > [...]
> > > > > > 
> > > > > > Applied to
> > > > > > 
> > > > > >    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
> > > > > 
> > > > > Thank you.
> > > > > 
> > > > > Unless there's a nuance intended in the merge series title that I'm unable
> > > > > to understand, it probably seems incomplete.
> > > > 
> > > > I believe it's an issue somewhere in the scripts. The long Subject line is
> > > > split in the mailbox and that's probably is not supported by the machinery.
> > > > 
> > > > You are not the only one who reports this issue.
> > > 
> > > While I'm not well educated on the machinery, I'm also seeing devm_kmemdup_array()
> > > introduction commit reordered in -next and thinking perhaps it can cause issues
> > > with bisect, especially after final merge into Linus' tree?
> > 
> > I;m not sure what you exactly pointing out here. Mark seems applied only
> > necessary part of the immutable tag, which have the same effect. The Git merges
> > only once the stuff as long as it has the same hash.
> 
> $ git describe
> next-20250306
> 
> $ git log --oneline --grep raag

--author="Raag ..."

...

> 1f4c7f3b3afa Merge patch series "Split devres APIs to device/devres.h and introduce devm_kmemdup_array()"
> a103b833ac38 devres: Introduce devm_kmemdup_array()
> b8c38ccb2ca5 input: ipaq-micro-keys: use devm_kmemdup_array()
> cdcc09a495a4 input: sparse-keymap: use devm_kmemdup_array()
> a0d78eec8839 iio: adc: xilinx-xadc-core: use devm_kmemdup_array()
> 86068aca7548 pinctrl: pxa2xx: use devm_kmemdup_array()
> 91bfcc7a2fdb pinctrl: tangier: use devm_kmemdup_array()
> d795fb90d6c6 pinctrl: cherryview: use devm_kmemdup_array()
> f192c8447f4e pinctrl: baytrail: copy communities using devm_kmemdup_array()
> 753764aa8eb5 pinctrl: intel: copy communities using devm_kmemdup_array()
> a21cad931276 driver core: Split devres APIs to device/devres.h
> 18311a766c58 err.h: move IOMEM_ERR_PTR() to err.h
> 
> I'm expecting commit a103b833ac38 to be before its users, or perhaps I'm
> doing something wrong here?

$ git tag --contains a103b833ac38
ib-devres-iio-input-pinctrl-v6.15
next-20250225
next-20250226
next-20250227
next-20250228
next-20250303
next-20250304
next-20250305
next-20250306

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/2] Convert regulator drivers to use devm_kmemdup_array()

[Andy Shevchenko]

On Thu, Mar 06, 2025 at 02:37:57PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 06, 2025 at 01:32:19PM +0200, Raag Jadav wrote:
> > On Thu, Mar 06, 2025 at 01:04:32PM +0200, Andy Shevchenko wrote:
> > > On Thu, Mar 06, 2025 at 12:14:59PM +0200, Raag Jadav wrote:
> > > > On Thu, Mar 06, 2025 at 11:19:31AM +0200, Andy Shevchenko wrote:
> > > > > On Thu, Mar 06, 2025 at 04:15:55AM +0200, Raag Jadav wrote:
> > > > > > On Fri, Feb 28, 2025 at 09:22:47PM +0000, Mark Brown wrote:
> > > > > > > On Fri, 28 Feb 2025 12:50:55 +0530, Raag Jadav wrote:
> > > > > > > > This series converts regulator drivers to use the newly introduced[1]
> > > > > > > > devm_kmemdup_array() helper. This depends on changes available on
> > > > > > > > immutable tag[2].
> > > > > > > > 
> > > > > > > > [1] https://lore.kernel.org/r/20250212062513.2254767-1-raag.jadav@intel.com
> > > > > > > > [2] https://lore.kernel.org/r/Z7xGpz3Q4Zj6YHx7@black.fi.intel.com
> > > > > > > > 
> > > > > > > > [...]
> > > > > > > 
> > > > > > > Applied to
> > > > > > > 
> > > > > > >    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
> > > > > > 
> > > > > > Thank you.
> > > > > > 
> > > > > > Unless there's a nuance intended in the merge series title that I'm unable
> > > > > > to understand, it probably seems incomplete.
> > > > > 
> > > > > I believe it's an issue somewhere in the scripts. The long Subject line is
> > > > > split in the mailbox and that's probably is not supported by the machinery.
> > > > > 
> > > > > You are not the only one who reports this issue.
> > > > 
> > > > While I'm not well educated on the machinery, I'm also seeing devm_kmemdup_array()
> > > > introduction commit reordered in -next and thinking perhaps it can cause issues
> > > > with bisect, especially after final merge into Linus' tree?
> > > 
> > > I;m not sure what you exactly pointing out here. Mark seems applied only
> > > necessary part of the immutable tag, which have the same effect. The Git merges
> > > only once the stuff as long as it has the same hash.
> > 
> > $ git describe
> > next-20250306
> > 
> > $ git log --oneline --grep raag
> 
> --author="Raag ..."

...

> > 1f4c7f3b3afa Merge patch series "Split devres APIs to device/devres.h and introduce devm_kmemdup_array()"
> > a103b833ac38 devres: Introduce devm_kmemdup_array()
> > b8c38ccb2ca5 input: ipaq-micro-keys: use devm_kmemdup_array()
> > cdcc09a495a4 input: sparse-keymap: use devm_kmemdup_array()
> > a0d78eec8839 iio: adc: xilinx-xadc-core: use devm_kmemdup_array()
> > 86068aca7548 pinctrl: pxa2xx: use devm_kmemdup_array()
> > 91bfcc7a2fdb pinctrl: tangier: use devm_kmemdup_array()
> > d795fb90d6c6 pinctrl: cherryview: use devm_kmemdup_array()
> > f192c8447f4e pinctrl: baytrail: copy communities using devm_kmemdup_array()
> > 753764aa8eb5 pinctrl: intel: copy communities using devm_kmemdup_array()
> > a21cad931276 driver core: Split devres APIs to device/devres.h
> > 18311a766c58 err.h: move IOMEM_ERR_PTR() to err.h
> > 
> > I'm expecting commit a103b833ac38 to be before its users, or perhaps I'm
> > doing something wrong here?
> 
> $ git tag --contains a103b833ac38
> ib-devres-iio-input-pinctrl-v6.15
> next-20250225
> next-20250226
> next-20250227
> next-20250228
> next-20250303
> next-20250304
> next-20250305
> next-20250306

Ah, and this:

$ git cat-file commit 753764aa8eb5
tree 7d99d7bb009118f7c0d8cbac9aa2ae321fc74785
parent a103b833ac3806b816bc993cba77d0b17cf801f1
author Raag Jadav <raag.jadav@intel.com> 1739341506 +0530
committer Andy Shevchenko <andriy.shevchenko@linux.intel.com> 1740391732 +0200

pinctrl: intel: copy communities using devm_kmemdup_array()
...

Most likely it uses the one which was merged earlier by Stephen, who merged
the ASoC before merging my immutable tag.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/2] Convert regulator drivers to use devm_kmemdup_array()

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

On Thu, Mar 06, 2025 at 01:04:32PM +0200, Andy Shevchenko wrote:

> I;m not sure what you exactly pointing out here. Mark seems applied only
> necessary part of the immutable tag, which have the same effect. The Git merges
> only once the stuff as long as it has the same hash.

Yes, there was a lot of random IIO stuff applied on top of the API
change so I rolled back to the API change.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]