* [PATCH][next] misc: bcm-vk: avoid -Wflex-array-member-not-at-end warning
@ 2025-03-13 22:36 Gustavo A. R. Silva
2025-03-14 0:04 ` Scott Branden
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2025-03-13 22:36 UTC (permalink / raw)
To: Scott Branden, Broadcom internal kernel review list,
Arnd Bergmann, Greg Kroah-Hartman
Cc: linux-kernel, Gustavo A. R. Silva, linux-hardening
Fix the following warning by removing unused flex-array member
`data` in `struct bcm_vk_peer_log`:
drivers/misc/bcm-vk/bcm_vk.h:415:32: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/misc/bcm-vk/bcm_vk.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/bcm-vk/bcm_vk.h b/drivers/misc/bcm-vk/bcm_vk.h
index 386884c2a263..9344c2366a4b 100644
--- a/drivers/misc/bcm-vk/bcm_vk.h
+++ b/drivers/misc/bcm-vk/bcm_vk.h
@@ -311,7 +311,6 @@ struct bcm_vk_peer_log {
u32 wr_idx;
u32 buf_size;
u32 mask;
- char data[];
};
/* max buf size allowed */
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] misc: bcm-vk: avoid -Wflex-array-member-not-at-end warning
2025-03-13 22:36 [PATCH][next] misc: bcm-vk: avoid -Wflex-array-member-not-at-end warning Gustavo A. R. Silva
@ 2025-03-14 0:04 ` Scott Branden
2025-03-14 0:49 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Scott Branden @ 2025-03-14 0:04 UTC (permalink / raw)
To: Gustavo A. R. Silva, Broadcom internal kernel review list,
Arnd Bergmann, Greg Kroah-Hartman
Cc: linux-kernel, linux-hardening
looks fine
On 2025-03-13 15:36, Gustavo A. R. Silva wrote:
> Fix the following warning by removing unused flex-array member
> `data` in `struct bcm_vk_peer_log`:
>
> drivers/misc/bcm-vk/bcm_vk.h:415:32: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> drivers/misc/bcm-vk/bcm_vk.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/bcm-vk/bcm_vk.h b/drivers/misc/bcm-vk/bcm_vk.h
> index 386884c2a263..9344c2366a4b 100644
> --- a/drivers/misc/bcm-vk/bcm_vk.h
> +++ b/drivers/misc/bcm-vk/bcm_vk.h
> @@ -311,7 +311,6 @@ struct bcm_vk_peer_log {
> u32 wr_idx;
> u32 buf_size;
> u32 mask;
> - char data[];
> };
>
> /* max buf size allowed */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] misc: bcm-vk: avoid -Wflex-array-member-not-at-end warning
2025-03-14 0:04 ` Scott Branden
@ 2025-03-14 0:49 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2025-03-14 0:49 UTC (permalink / raw)
To: Scott Branden, Gustavo A. R. Silva,
Broadcom internal kernel review list, Arnd Bergmann,
Greg Kroah-Hartman
Cc: linux-kernel, linux-hardening
On 14/03/25 10:34, Scott Branden wrote:
> looks fine
>
> On 2025-03-13 15:36, Gustavo A. R. Silva wrote:
>> Fix the following warning by removing unused flex-array member
>> `data` in `struct bcm_vk_peer_log`:
>>
>> drivers/misc/bcm-vk/bcm_vk.h:415:32: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-
>> end]
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> Acked-by: Scott Branden <scott.branden@broadcom.com>
Thanks! :)
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-14 0:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-13 22:36 [PATCH][next] misc: bcm-vk: avoid -Wflex-array-member-not-at-end warning Gustavo A. R. Silva
2025-03-14 0:04 ` Scott Branden
2025-03-14 0:49 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox