From: Ingo Molnar <mingo@kernel.org>
To: Sohil Mehta <sohil.mehta@intel.com>
Cc: Brian Gerst <brgerst@gmail.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
"H . Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
Juergen Gross <jgross@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 4/5] x86/syscall/x32: Move x32 syscall table
Date: Fri, 14 Mar 2025 10:34:15 +0100 [thread overview]
Message-ID: <Z9P4Fx9Kl7mkSh9F@gmail.com> (raw)
In-Reply-To: <a30872ce-3acf-4d6a-8d96-c073c6f33895@intel.com>
* Sohil Mehta <sohil.mehta@intel.com> wrote:
> > +#ifdef CONFIG_X86_X32_ABI
> > +long x32_sys_call(const struct pt_regs *regs, unsigned int nr)
> > +{
> > + switch (nr) {
> > + #include <asm/syscalls_x32.h>
> > + default: return __x64_sys_ni_syscall(regs);
> > + }
> > +};
>
> There seems to be a stray semicolon here. The original code also has it
> but it doesn't seem necessary.
BTW., seeing that you've gone through this series with a fine comb I've
added your Reviewed-by tag to the series (with the caveat that the
details you've pointed out will be addressed in followup patches).
Let me know if that's not OK.
Thanks,
Ingo
next prev parent reply other threads:[~2025-03-14 9:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 18:22 [PATCH 0/5] x86/entry: Break up common.c Brian Gerst
2025-03-13 18:22 ` [PATCH 1/5] x86/xen: Move Xen upcall handler Brian Gerst
2025-03-14 7:37 ` Juergen Gross
2025-03-14 9:47 ` [tip: x86/cpu] x86/xen: Move Xen upcall handler to Xen specific code files tip-bot2 for Brian Gerst
2025-03-14 9:53 ` Jürgen Groß
2025-03-14 10:08 ` Ingo Molnar
2025-03-14 10:14 ` Jürgen Groß
2025-03-13 18:22 ` [PATCH 2/5] x86/syscall/32: Move 32-bit syscall dispatch code Brian Gerst
2025-03-13 23:44 ` Sohil Mehta
2025-03-14 1:25 ` Brian Gerst
2025-03-14 9:27 ` Ingo Molnar
2025-03-14 9:46 ` [tip: x86/cpu] x86/syscall/32: Move the 32-bit syscall dispatch code to arch/x86/entry/syscall_32.c tip-bot2 for Brian Gerst
2025-03-13 18:22 ` [PATCH 3/5] x86/syscall/64: Move 64-bit syscall dispatch code Brian Gerst
2025-03-14 9:46 ` [tip: x86/cpu] x86/syscall/64: Move the 64-bit syscall dispatch code to arch/x86/entry/syscall_64.c tip-bot2 for Brian Gerst
2025-03-13 18:22 ` [PATCH 4/5] x86/syscall/x32: Move x32 syscall table Brian Gerst
2025-03-13 23:47 ` Sohil Mehta
2025-03-14 9:25 ` Ingo Molnar
2025-03-14 9:34 ` Ingo Molnar [this message]
2025-03-14 16:02 ` Sohil Mehta
2025-03-14 9:46 ` [tip: x86/cpu] x86/syscall/x32: Move the x32 syscall table to arch/x86/entry/syscall_64.c tip-bot2 for Brian Gerst
2025-03-13 18:22 ` [PATCH 5/5] x86/syscall: Move sys_ni_syscall() Brian Gerst
2025-03-14 9:46 ` [tip: x86/cpu] x86/syscall: Move sys_ni_syscall() to arch/x86/kernel/process.c tip-bot2 for Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9P4Fx9Kl7mkSh9F@gmail.com \
--to=mingo@kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox