From: Guomin chen <guomin.chen@cixtech.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
"Jassi Brar" <jassisinghbrar@gmail.com>,
"Rob Herring" <robh@kernel.org>,
",Conor Dooley" <conor+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, cix-kernel-upstream@cixtech.com,
Peter Chen <peter.chen@cixtech.com>,
Lihua Liu <Lihua.Liu@cixtech.com>
Subject: Re: [PATCH 1/2] dt-bindings: mailbox: cix: add device tree binding documentation.
Date: Fri, 14 Mar 2025 08:21:59 +0000 [thread overview]
Message-ID: <Z9PnJ0GKhmoHM7nr@gchen> (raw)
In-Reply-To: <63bba0e1-c1d6-4a83-b376-bcf89cb09533@kernel.org>
On Fri, Mar 14, 2025 at 08:25:40AM +0100, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
>
> On 13/03/2025 14:24, Guomin Chen wrote:
> > From: Guomin Chen <Guomin.Chen@cixtech.com>
> >
> > This patch adds device tree binding for mailbox from Cixtech.
> >
> > Reviewed-by: Peter Chen <peter.chen@cixtech.com>
> > Signed-off-by: Lihua Liu <Lihua.Liu@cixtech.com>
> > Signed-off-by: Guomin Chen <Guomin.Chen@cixtech.com>
>
> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
>
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.
>
> Please kindly resend and include all necessary To/Cc entries.
> </form letter>
>
> Best regards,
> Krzysztof
Thank you for your hint. Although I have used scripts/get_maintainer.pl to
obtain the cc list, I do lack devicetree@vger.kernel.org
I will copy it in the next version. Thank you very much.
Best regards,
Guomin Chen
next prev parent reply other threads:[~2025-03-14 8:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 13:24 [PATCH 1/2] dt-bindings: mailbox: cix: add device tree binding documentation Guomin Chen
2025-03-13 13:28 ` Krzysztof Kozlowski
2025-03-14 8:09 ` Guomin chen
2025-03-14 8:13 ` Krzysztof Kozlowski
2025-03-14 7:25 ` Krzysztof Kozlowski
2025-03-14 8:21 ` Guomin chen [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-03-13 13:22 Guomin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9PnJ0GKhmoHM7nr@gchen \
--to=guomin.chen@cixtech.com \
--cc=Lihua.Liu@cixtech.com \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@cixtech.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox