Re: [PATCH 1/2] dt-bindings: mailbox: cix: add device tree binding documentation.

[Krzysztof Kozlowski <krzk@kernel.org>]

On 14/03/2025 09:09, Guomin chen wrote:
>>
>>> +
>>> +      This controller supports three types of unidirectional channels, they are
>>> +      1 register based channel, 1 fifo based channel and 8 fast channels.
>>> +      A total of 10 channels for each controller. Following types are
>>> +      supported:
>>> +      channel 0_7 - Fast channel with 32bit transmit register and IRQ support.
>>> +      channel 8   - Reg based channel with 32*32bit transsmit register and
>>> +                    Doorbell+transmit acknowledgment IRQ support
>>> +      channel 9   - Fifo based channel with 32*32bit depth fifo and IRQ support.
>>> +    const: 1
>>> +
>>> +  cix,mbox-dir:
>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>> +    description: Direction of the mailbox (0:TX or 1:RX)
>>> +    enum: [0, 1]
>>
>> I don't understand why do you need it. By not sending us driver patch,
>> you are not making it easier. Why would provider care how consumers use
>> the mbox channel? Maybe consumer should choose the direction?
>>
> 
> As for the mbox-dir property, my driver code has already been submitted. 

There is no thing in this thread, so next time be sure you use standard
submitting process, so your work will be threaded.

> On the Cixtech Soc platform, although each mbox is unidirectional, 
> there are multiple mboxes—some for reading and some for writing. 

So all mboxes in a controller have the same direction or not? Do you
configure it or is it defined by hardware?

> Therefore, the mbox controller has added the mbox-dir property. 
> 
> Consumers only need to reference the corresponding mbox controller node, 
> and whether it is for reading or writing is already determined by the mbox controller, 
> without needing to further understand the mbox-dir property.

Don't explain how DT works, I know. Why this property is needed in DT in
the first place?


Best regards,
Krzysztof