From: Jarkko Sakkinen <jarkko@kernel.org>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
linux-integrity@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm/tpm_ftpm_tee: fix struct ftpm_tee_private documentation
Date: Fri, 14 Mar 2025 16:51:19 +0200 [thread overview]
Message-ID: <Z9RCZ_L6HS0GZhWL@kernel.org> (raw)
In-Reply-To: <20250313093717.69270-1-sgarzare@redhat.com>
On Thu, Mar 13, 2025 at 10:37:17AM +0100, Stefano Garzarella wrote:
> The `state` member in `struct ftpm_tee_private` is in the documentation,
> but it has never been in the implementation since the commit 09e574831b27
> ("tpm/tpm_ftpm_tee: A driver for firmware TPM running inside TEE") that
> introduced it.
>
> Remove it to have a match between documentation and implementation.
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> drivers/char/tpm/tpm_ftpm_tee.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_ftpm_tee.h b/drivers/char/tpm/tpm_ftpm_tee.h
> index f98daa7bf68c..e39903b7ea07 100644
> --- a/drivers/char/tpm/tpm_ftpm_tee.h
> +++ b/drivers/char/tpm/tpm_ftpm_tee.h
> @@ -21,7 +21,6 @@
> /**
> * struct ftpm_tee_private - fTPM's private data
> * @chip: struct tpm_chip instance registered with tpm framework.
> - * @state: internal state
> * @session: fTPM TA session identifier.
> * @resp_len: cached response buffer length.
> * @resp_buf: cached response buffer.
> --
> 2.48.1
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
[applying next week]
BR, Jarkko
prev parent reply other threads:[~2025-03-14 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 9:37 [PATCH] tpm/tpm_ftpm_tee: fix struct ftpm_tee_private documentation Stefano Garzarella
2025-03-14 14:51 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9RCZ_L6HS0GZhWL@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox