* [PATCH] tpm/tpm_ftpm_tee: fix struct ftpm_tee_private documentation
@ 2025-03-13 9:37 Stefano Garzarella
2025-03-14 14:51 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Stefano Garzarella @ 2025-03-13 9:37 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: Peter Huewe, linux-integrity, Jason Gunthorpe, linux-kernel,
Stefano Garzarella
The `state` member in `struct ftpm_tee_private` is in the documentation,
but it has never been in the implementation since the commit 09e574831b27
("tpm/tpm_ftpm_tee: A driver for firmware TPM running inside TEE") that
introduced it.
Remove it to have a match between documentation and implementation.
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
drivers/char/tpm/tpm_ftpm_tee.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/tpm/tpm_ftpm_tee.h b/drivers/char/tpm/tpm_ftpm_tee.h
index f98daa7bf68c..e39903b7ea07 100644
--- a/drivers/char/tpm/tpm_ftpm_tee.h
+++ b/drivers/char/tpm/tpm_ftpm_tee.h
@@ -21,7 +21,6 @@
/**
* struct ftpm_tee_private - fTPM's private data
* @chip: struct tpm_chip instance registered with tpm framework.
- * @state: internal state
* @session: fTPM TA session identifier.
* @resp_len: cached response buffer length.
* @resp_buf: cached response buffer.
--
2.48.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tpm/tpm_ftpm_tee: fix struct ftpm_tee_private documentation
2025-03-13 9:37 [PATCH] tpm/tpm_ftpm_tee: fix struct ftpm_tee_private documentation Stefano Garzarella
@ 2025-03-14 14:51 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2025-03-14 14:51 UTC (permalink / raw)
To: Stefano Garzarella
Cc: Peter Huewe, linux-integrity, Jason Gunthorpe, linux-kernel
On Thu, Mar 13, 2025 at 10:37:17AM +0100, Stefano Garzarella wrote:
> The `state` member in `struct ftpm_tee_private` is in the documentation,
> but it has never been in the implementation since the commit 09e574831b27
> ("tpm/tpm_ftpm_tee: A driver for firmware TPM running inside TEE") that
> introduced it.
>
> Remove it to have a match between documentation and implementation.
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> drivers/char/tpm/tpm_ftpm_tee.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_ftpm_tee.h b/drivers/char/tpm/tpm_ftpm_tee.h
> index f98daa7bf68c..e39903b7ea07 100644
> --- a/drivers/char/tpm/tpm_ftpm_tee.h
> +++ b/drivers/char/tpm/tpm_ftpm_tee.h
> @@ -21,7 +21,6 @@
> /**
> * struct ftpm_tee_private - fTPM's private data
> * @chip: struct tpm_chip instance registered with tpm framework.
> - * @state: internal state
> * @session: fTPM TA session identifier.
> * @resp_len: cached response buffer length.
> * @resp_buf: cached response buffer.
> --
> 2.48.1
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
[applying next week]
BR, Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-14 14:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-13 9:37 [PATCH] tpm/tpm_ftpm_tee: fix struct ftpm_tee_private documentation Stefano Garzarella
2025-03-14 14:51 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox