* [PATCH] fork: Use __vmalloc_node() for stack allocation
@ 2025-03-17 16:36 Uladzislau Rezki (Sony)
2025-03-18 8:23 ` Michal Hocko
0 siblings, 1 reply; 2+ messages in thread
From: Uladzislau Rezki (Sony) @ 2025-03-17 16:36 UTC (permalink / raw)
To: LKML, Andrew Morton
Cc: Christian Brauner, Oleg Nesterov, Tejun Heo, Uladzislau Rezki,
Oleksiy Avramchenko
Replace __vmalloc_node_range() by the __vmalloc_node() function.
The last variant requires less parameters and it uses exactly the
same arguments which are partly now hidden inside __vmalloc_node()
function.
This change does not change any functionality. It makes the code
a bit simpler.
Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
---
kernel/fork.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/kernel/fork.c b/kernel/fork.c
index 2fa2a3582925..72d9e7c7639e 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -311,11 +311,9 @@ static int alloc_thread_stack_node(struct task_struct *tsk, int node)
* so memcg accounting is performed manually on assigning/releasing
* stacks to tasks. Drop __GFP_ACCOUNT.
*/
- stack = __vmalloc_node_range(THREAD_SIZE, THREAD_ALIGN,
- VMALLOC_START, VMALLOC_END,
+ stack = __vmalloc_node(THREAD_SIZE, THREAD_ALIGN,
THREADINFO_GFP & ~__GFP_ACCOUNT,
- PAGE_KERNEL,
- 0, node, __builtin_return_address(0));
+ node, __builtin_return_address(0));
if (!stack)
return -ENOMEM;
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fork: Use __vmalloc_node() for stack allocation
2025-03-17 16:36 [PATCH] fork: Use __vmalloc_node() for stack allocation Uladzislau Rezki (Sony)
@ 2025-03-18 8:23 ` Michal Hocko
0 siblings, 0 replies; 2+ messages in thread
From: Michal Hocko @ 2025-03-18 8:23 UTC (permalink / raw)
To: Uladzislau Rezki (Sony)
Cc: LKML, Andrew Morton, Christian Brauner, Oleg Nesterov, Tejun Heo,
Oleksiy Avramchenko
On Mon 17-03-25 17:36:14, Uladzislau Rezki wrote:
> Replace __vmalloc_node_range() by the __vmalloc_node() function.
> The last variant requires less parameters and it uses exactly the
> same arguments which are partly now hidden inside __vmalloc_node()
> function.
>
> This change does not change any functionality. It makes the code
> a bit simpler.
>
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> kernel/fork.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 2fa2a3582925..72d9e7c7639e 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -311,11 +311,9 @@ static int alloc_thread_stack_node(struct task_struct *tsk, int node)
> * so memcg accounting is performed manually on assigning/releasing
> * stacks to tasks. Drop __GFP_ACCOUNT.
> */
> - stack = __vmalloc_node_range(THREAD_SIZE, THREAD_ALIGN,
> - VMALLOC_START, VMALLOC_END,
> + stack = __vmalloc_node(THREAD_SIZE, THREAD_ALIGN,
> THREADINFO_GFP & ~__GFP_ACCOUNT,
> - PAGE_KERNEL,
> - 0, node, __builtin_return_address(0));
> + node, __builtin_return_address(0));
> if (!stack)
> return -ENOMEM;
>
> --
> 2.39.5
>
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-18 8:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-17 16:36 [PATCH] fork: Use __vmalloc_node() for stack allocation Uladzislau Rezki (Sony)
2025-03-18 8:23 ` Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox