From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Aryan Srivastava <aryan.srivastava@alliedtelesis.co.nz>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Markus Elfring <Markus.Elfring@web.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Robert Richter <rric@kernel.org>
Subject: Re: [PATCH v13 2/3] i2c: octeon: remove 10-bit addressing support
Date: Wed, 19 Mar 2025 06:41:24 +0100 [thread overview]
Message-ID: <Z9pZBDbI2MD7ybEL@shikoro> (raw)
In-Reply-To: <j2w45gphxir2hmzr6nhzyrlgj55lhsbkzczpf5bq72pzk26kwp@zncvv3hpfcoc>
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
> The datasheet I have isn't very clear on this part. Also, I'd
> like to know if there's any product line that could be negatively
> impacted by this patch.
In my whole I2C life, I have neither seen a target supporting 10-bit
addressing nor a a system that uses 10-bit addressing. I am even tempted
to remove support from the kernel omce in a while. If the support is
broken in this driver, it can be removed. A working version (if
possible) can be added again by someone who needs it. I am taking bets
it will be "never". Besides, the driver never set I2C_FUNC_10BIT_ADDR,
so it really shouldn't have been used anywhere.
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-03-19 5:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 2:16 [PATCH v13 0/3] i2c: octeon: add block-mode r/w Aryan Srivastava
2025-03-18 2:16 ` [PATCH v13 1/3] i2c: octeon: fix return commenting Aryan Srivastava
2025-03-18 11:46 ` Andy Shevchenko
2025-03-18 2:16 ` [PATCH v13 2/3] i2c: octeon: remove 10-bit addressing support Aryan Srivastava
2025-03-18 11:50 ` Andy Shevchenko
2025-03-19 0:21 ` Andi Shyti
2025-03-19 5:41 ` Wolfram Sang [this message]
2025-03-19 9:47 ` Andi Shyti
2025-03-19 10:08 ` Wolfram Sang
2025-03-18 2:16 ` [PATCH v13 3/3] i2c: octeon: add block-mode i2c operations Aryan Srivastava
2025-03-19 22:19 ` Andi Shyti
2025-03-20 1:36 ` Aryan Srivastava
2025-03-20 9:01 ` Andi Shyti
2025-03-24 18:14 ` Aryan Srivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9pZBDbI2MD7ybEL@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=Markus.Elfring@web.de \
--cc=andi.shyti@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=aryan.srivastava@alliedtelesis.co.nz \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox