* [PATCH] MIPS: cm: Fix warning if MIPS_CM is disabled
@ 2025-02-28 14:37 Thomas Bogendoerfer
2025-03-19 9:24 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Bogendoerfer @ 2025-02-28 14:37 UTC (permalink / raw)
To: Gregory CLEMENT, linux-mips, linux-kernel
Commit e27fbe16af5c ("MIPS: cm: Detect CM quirks from device tree")
introduced
arch/mips/include/asm/mips-cm.h:119:13: error: ‘mips_cm_update_property’
defined but not used [-Werror=unused-function]
Fix this by making empty function implementation inline
Fixes: e27fbe16af5c ("MIPS: cm: Detect CM quirks from device tree")
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
arch/mips/include/asm/mips-cm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/include/asm/mips-cm.h b/arch/mips/include/asm/mips-cm.h
index 3bfe0633b576..407f253bb4a1 100644
--- a/arch/mips/include/asm/mips-cm.h
+++ b/arch/mips/include/asm/mips-cm.h
@@ -116,7 +116,7 @@ static inline bool mips_cm_present(void)
#ifdef CONFIG_MIPS_CM
extern void mips_cm_update_property(void);
#else
-static void mips_cm_update_property(void) {}
+static inline void mips_cm_update_property(void) {}
#endif
/**
--
2.35.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] MIPS: cm: Fix warning if MIPS_CM is disabled
2025-02-28 14:37 [PATCH] MIPS: cm: Fix warning if MIPS_CM is disabled Thomas Bogendoerfer
@ 2025-03-19 9:24 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2025-03-19 9:24 UTC (permalink / raw)
To: Gregory CLEMENT, linux-mips, linux-kernel
On Fri, Feb 28, 2025 at 03:37:02PM +0100, Thomas Bogendoerfer wrote:
> Commit e27fbe16af5c ("MIPS: cm: Detect CM quirks from device tree")
> introduced
>
> arch/mips/include/asm/mips-cm.h:119:13: error: ‘mips_cm_update_property’
> defined but not used [-Werror=unused-function]
>
> Fix this by making empty function implementation inline
>
> Fixes: e27fbe16af5c ("MIPS: cm: Detect CM quirks from device tree")
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> ---
> arch/mips/include/asm/mips-cm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/mips-cm.h b/arch/mips/include/asm/mips-cm.h
> index 3bfe0633b576..407f253bb4a1 100644
> --- a/arch/mips/include/asm/mips-cm.h
> +++ b/arch/mips/include/asm/mips-cm.h
> @@ -116,7 +116,7 @@ static inline bool mips_cm_present(void)
> #ifdef CONFIG_MIPS_CM
> extern void mips_cm_update_property(void);
> #else
> -static void mips_cm_update_property(void) {}
> +static inline void mips_cm_update_property(void) {}
> #endif
>
> /**
> --
> 2.35.3
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-19 10:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-28 14:37 [PATCH] MIPS: cm: Fix warning if MIPS_CM is disabled Thomas Bogendoerfer
2025-03-19 9:24 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox