From: Bobby Eshleman <bobbyeshleman@gmail.com>
To: Arseniy Krasnov <avkrasnov@sberdevices.ru>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Bobby Eshleman <bobby.eshleman@bytedance.com>,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@sberdevices.ru, oxffffaa@gmail.com
Subject: Re: [PATCH RESEND net v4 2/4] virtio/vsock: remove redundant 'skb_pull()' call
Date: Wed, 8 Mar 2023 15:15:04 +0000 [thread overview]
Message-ID: <ZAimeNvNmdFz2/ns@bullseye> (raw)
In-Reply-To: <75e3f51b-2848-d3ce-a995-4ac8320663f6@sberdevices.ru>
On Tue, Mar 14, 2023 at 02:06:53PM +0300, Arseniy Krasnov wrote:
> Since we now no longer use 'skb->len' to update credit, there is no sense
> to update skbuff state, because it is used only once after dequeue to
> copy data and then will be released.
>
> Fixes: 71dc9ec9ac7d ("virtio/vsock: replace virtio_vsock_pkt with sk_buff")
> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> net/vmw_vsock/virtio_transport_common.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
> index 618680fd9906..9a411475e201 100644
> --- a/net/vmw_vsock/virtio_transport_common.c
> +++ b/net/vmw_vsock/virtio_transport_common.c
> @@ -465,7 +465,6 @@ static int virtio_transport_seqpacket_do_dequeue(struct vsock_sock *vsk,
> dequeued_len = err;
> } else {
> user_buf_len -= bytes_to_copy;
> - skb_pull(skb, bytes_to_copy);
> }
>
> spin_lock_bh(&vvs->rx_lock);
> --
> 2.25.1
Acked-by: Bobby Eshleman <bobby.eshleman@bytedance.com>
next prev parent reply other threads:[~2023-03-14 16:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 11:03 [PATCH RESEND net v4 0/4] several updates to virtio/vsock Arseniy Krasnov
2023-03-14 11:05 ` [PATCH RESEND net v4 1/4] virtio/vsock: don't use skbuff state to account credit Arseniy Krasnov
2023-03-08 15:11 ` Bobby Eshleman
2023-03-14 11:06 ` [PATCH RESEND net v4 2/4] virtio/vsock: remove redundant 'skb_pull()' call Arseniy Krasnov
2023-03-08 15:15 ` Bobby Eshleman [this message]
2023-03-14 11:08 ` [PATCH RESEND net v4 3/4] virtio/vsock: don't drop skbuff on copy failure Arseniy Krasnov
2023-03-08 15:16 ` Bobby Eshleman
2023-03-14 11:09 ` [PATCH RESEND net v4 4/4] test/vsock: copy to user failure test Arseniy Krasnov
2023-03-16 17:30 ` [PATCH RESEND net v4 0/4] several updates to virtio/vsock patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAimeNvNmdFz2/ns@bullseye \
--to=bobbyeshleman@gmail.com \
--cc=avkrasnov@sberdevices.ru \
--cc=bobby.eshleman@bytedance.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@sberdevices.ru \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oxffffaa@gmail.com \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox