From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joy Chakraborty <joychakr@google.com>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
manugautam@google.com, rohitner@google.com
Subject: Re: [PATCH v5 2/2] spi: dw: Add dma controller capability checks
Date: Tue, 11 Apr 2023 18:11:39 +0300 [thread overview]
Message-ID: <ZDV4q79uHy5aGdT1@smile.fi.intel.com> (raw)
In-Reply-To: <CAOSNQF0R7p7kW04w0nKF2egv1+8NrMhSXpggunYhjQnA+v-qMQ@mail.gmail.com>
On Tue, Apr 11, 2023 at 08:30:41PM +0530, Joy Chakraborty wrote:
> On Tue, Apr 11, 2023 at 5:48 PM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > On Thu, Mar 30, 2023 at 06:34:50AM +0000, Joy Chakraborty wrote:
...
> > > +static enum dma_slave_buswidth dw_spi_dma_convert_width(u8 n_bytes);
> >
> > Can we avoid forward declarations please?
>
> We can, but for that I would have to move this api somewhere else in
> the file is that acceptable?
Yes, but make it in a separate change as a preparation for this one.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-04-11 15:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 6:34 [PATCH v5 0/2] spi: dw: DW SPI DMA Driver updates Joy Chakraborty
2023-03-30 6:34 ` [PATCH v5 1/2] spi: dw: Add 32 bpw support to DW DMA Controller Joy Chakraborty
2023-04-11 12:13 ` Andy Shevchenko
2023-04-11 14:11 ` Serge Semin
2023-04-11 14:30 ` Joy Chakraborty
2023-04-11 14:39 ` Serge Semin
2023-04-11 14:46 ` Andy Shevchenko
2023-04-11 15:09 ` Serge Semin
2023-04-11 15:17 ` Andy Shevchenko
2023-04-11 15:18 ` Joy Chakraborty
2023-04-11 16:21 ` Andy Shevchenko
2023-04-11 19:41 ` Joy Chakraborty
2023-04-12 9:21 ` Joy Chakraborty
2023-04-12 13:24 ` Andy Shevchenko
2023-04-13 4:07 ` Joy Chakraborty
2023-04-13 13:47 ` Serge Semin
2023-04-13 20:23 ` Joy Chakraborty
2023-03-30 6:34 ` [PATCH v5 2/2] spi: dw: Add dma controller capability checks Joy Chakraborty
2023-04-11 12:18 ` Andy Shevchenko
2023-04-11 14:37 ` Serge Semin
2023-04-11 14:47 ` Serge Semin
2023-04-11 14:49 ` Andy Shevchenko
2023-04-11 15:00 ` Joy Chakraborty
2023-04-11 15:07 ` Joy Chakraborty
2023-04-11 15:15 ` Andy Shevchenko
2023-04-13 13:36 ` Serge Semin
2023-04-11 15:11 ` Andy Shevchenko [this message]
2023-04-11 5:12 ` [PATCH v5 0/2] spi: dw: DW SPI DMA Driver updates Serge Semin
2023-04-11 12:11 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDV4q79uHy5aGdT1@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=broonie@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=joychakr@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=manugautam@google.com \
--cc=rohitner@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox