From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peter Enderborg <Peter.Enderborg@sony.com>
Cc: Mark Brown <broonie@kernel.org>, Yingsha Xu <ysxu@hust.edu.cn>,
Serge Semin <fancer.lancer@gmail.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: remove return value check of debugfs_create_dir()
Date: Tue, 25 Apr 2023 07:31:13 +0200 [thread overview]
Message-ID: <ZEdlofQJ6cfSOLmD@kroah.com> (raw)
In-Reply-To: <f58c04d3-df1d-1dad-03fa-50457f39d9dc@sony.com>
On Mon, Apr 24, 2023 at 03:54:13PM +0200, Peter Enderborg wrote:
> On 4/24/23 15:22, Greg Kroah-Hartman wrote:
> > On Mon, Apr 24, 2023 at 03:17:09PM +0200, Peter Enderborg wrote:
> >> On 4/24/23 14:53, Greg Kroah-Hartman wrote:
> >>>>> We can do things with the debug information without filesystem enabled.
> >>> What exactly do you mean by this?
> >>>
> >>>
> >> We can read out data from kernel with a ramdumper and analyse with crash.
> >>
> >> See https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/kernel_administration_guide/kernel_crash_dump_guide
> >>
> >> If it is useful or not I can not say, but the dws->regset. is lost and can not be read with a post mortem debugger.
> > What is "dws"? What is "regset"?
>
> That is from the patch. It is used as an example.
>
>
> > What is the root problem here?
>
> That it is a mater of taste. It should not be a mater of taste.
>
> if (!dws->debugfs)
> return -ENOMEM;
Right here, you abort the normal operation of the driver if something
went wrong with debugfs, which is not a good idea. That's the goal
here, nothing else.
thanks,
greg k-h
prev parent reply other threads:[~2023-04-25 5:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 6:11 [PATCH] spi: remove return value check of debugfs_create_dir() Yingsha Xu
2023-04-24 11:54 ` Mark Brown
2023-04-24 12:20 ` Peter Enderborg
2023-04-24 12:32 ` Mark Brown
2023-04-24 12:53 ` Greg Kroah-Hartman
2023-04-24 13:00 ` Mark Brown
2023-04-24 13:08 ` Greg Kroah-Hartman
2023-04-24 13:17 ` Mark Brown
2023-04-24 13:17 ` Peter Enderborg
2023-04-24 13:22 ` Greg Kroah-Hartman
2023-04-24 13:54 ` Peter Enderborg
2023-04-25 5:31 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEdlofQJ6cfSOLmD@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Peter.Enderborg@sony.com \
--cc=broonie@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ysxu@hust.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox