From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Cong Yang <yangcong5@huaqin.corp-partner.google.com>,
benjamin.tissoires@redhat.com, devicetree@vger.kernel.org,
hsinyi@google.com, jikos@kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, mka@chromium.org
Subject: Re: [v2 1/2] HID: i2c-hid: elan: Add ili9882t timing
Date: Tue, 30 May 2023 14:24:32 -0700 [thread overview]
Message-ID: <ZHZpkGYYkYK4SrHX@google.com> (raw)
In-Reply-To: <CAD=FV=Xpe=zOeq2pG17Q0n_SZZHAFmaE+6C=SnuHqnHN6uObog@mail.gmail.com>
On Mon, May 22, 2023 at 08:27:38AM -0700, Doug Anderson wrote:
> Hi,
>
> On Fri, May 19, 2023 at 10:07 PM Cong Yang
> <yangcong5@huaqin.corp-partner.google.com> wrote:
> >
> > The ili9882t is a TDDI IC ((Touch with Display Driver)). It requires the
> > panel reset gpio to be high before i2c commands. Use a longer delay in
> > post_power_delay_ms to ensure the poweron sequence.
> >
> > Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com>
> > ---
> > drivers/hid/i2c-hid/i2c-hid-of-elan.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
>
> This seems OK to me. The one thing I'd also do is to update the
> Kconfig description to say that this driver is also used for Ilitek. I
> think it's fine to keep the symbol name as I2C_HID_OF_ELAN but just
> change the description.
Does ilitek have the same set of regulators, etc, or is it only the
timing? I'd probably make it a separate mini-driver...
Thanks.
--
Dmitry
next prev parent reply other threads:[~2023-05-30 21:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 9:01 [PATCH] HID: i2c-hid: goodix: Add ili9882t timing Cong Yang
2023-05-19 14:01 ` Doug Anderson
2023-05-20 5:06 ` [v2 0/2] " Cong Yang
2023-05-20 5:06 ` [v2 1/2] HID: i2c-hid: elan: " Cong Yang
2023-05-22 15:27 ` Doug Anderson
2023-05-30 21:24 ` Dmitry Torokhov [this message]
2023-05-20 5:06 ` [v2 2/2] dt-bindings: input: touchscreen: Add ilitek 9882T touchscreen chip Cong Yang
2023-05-22 15:33 ` Doug Anderson
2023-05-30 11:56 ` Krzysztof Kozlowski
2023-05-30 16:58 ` Doug Anderson
[not found] ` <CAHwB_N+ZpCAYftCLRwyNo2wCca+JHfGJc0_rJ=jwJcU0mbG=Dw@mail.gmail.com>
2023-06-01 15:40 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHZpkGYYkYK4SrHX@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=hsinyi@google.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=yangcong5@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox